From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnwBq-0000b5-WB for qemu-devel@nongnu.org; Tue, 03 Dec 2013 15:03:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnwBh-0004ta-V4 for qemu-devel@nongnu.org; Tue, 03 Dec 2013 15:03:26 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:38610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnwBh-0004pM-Nz for qemu-devel@nongnu.org; Tue, 03 Dec 2013 15:03:17 -0500 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Dec 2013 13:03:15 -0700 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1381347758-5016-1-git-send-email-hdegoede@redhat.com> References: <1381347758-5016-1-git-send-email-hdegoede@redhat.com> Message-ID: <20131203200304.16849.11017@loki> Date: Tue, 03 Dec 2013 14:03:04 -0600 Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH 1/2] audio: honor QEMU_AUDIO_TIMER_PERIOD instead of waking up every *nano* second List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede , malc Cc: Paolo Bonzini , qemu-stable@nongnu.org, Alex Bligh , qemu-devel@nongnu.org Quoting Hans de Goede (2013-10-09 14:42:37) > Now that we no longer have MIN_REARM_TIMER_NS a bug in the audio subsys h= as > clearly shown it self by trying to make a timer fire every nano second. > = > Note we have a similar problem in 1.6, 1.5 and older but there > MIN_REARM_TIMER_NS limits the wakeups caused by audio being active to > 4000 times / second. This still causes a host cpu load of 50 % for simply > playing audio, where as with this patch git master is at 13%, so we should > backport this to 1.5 and 1.6 too. > = > Note this will not apply to 1.5 and 1.6 as is. What needs to be changed? Wouldn't this patch also restore the 250hz frequency for 1.6, as it was pre-0.14? > = > Cc: qemu-stable@nongnu.org > Signed-off-by: Hans de Goede > --- > audio/audio.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > = > diff --git a/audio/audio.c b/audio/audio.c > index af4cdf6..b3db679 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -1124,7 +1124,8 @@ static int audio_is_timer_needed (void) > static void audio_reset_timer (AudioState *s) > { > if (audio_is_timer_needed ()) { > - timer_mod (s->ts, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 1); > + timer_mod (s->ts, > + qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + conf.period.ticks); > } > else { > timer_del (s->ts); > -- = > 1.8.3.1