From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41951)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Vny1K-0004Vz-EZ
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 17:00:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Vny14-0002E3-Hn
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 17:00:42 -0500
Received: from e8.ny.us.ibm.com ([32.97.182.138]:59506)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Vny14-0002Dw-CH
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 17:00:26 -0500
Received: from /spool/local
	by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Tue, 3 Dec 2013 17:00:25 -0500
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <EA07A9E4FF85FEDC7DF664EB@nimrod.local>
References: <1381347758-5016-1-git-send-email-hdegoede@redhat.com>
	<20131203200304.16849.11017@loki>
	<EA07A9E4FF85FEDC7DF664EB@nimrod.local>
Message-ID: <20131203220019.661.8899@loki>
Date: Tue, 03 Dec 2013 16:00:19 -0600
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH 1/2] audio: honor
 QEMU_AUDIO_TIMER_PERIOD instead of waking up every *nano* second
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>, Hans de Goede <hdegoede@redhat.com>, malc <av1474@comtv.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org

Quoting Alex Bligh (2013-12-03 15:17:11)
> --On 3 December 2013 14:03:04 -0600 Michael Roth =

> <mdroth@linux.vnet.ibm.com> wrote:
> =

> >> Note this will not apply to 1.5 and 1.6 as is.
> >
> > What needs to be changed? Wouldn't this patch also restore the 250hz
> > frequency for 1.6, as it was pre-0.14?
> =

> The function names have changed as have the clock names.
> At a guess (cut and paste diff, completely untested), you
> need something like this:
> =

> diff --git a/audio/audio.c b/audio/audio.c
> index 02bb886..45d146e 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -1124,7 +1124,8 @@ static int audio_is_timer_needed (void)
>  static void audio_reset_timer (AudioState *s)
>  {
>      if (audio_is_timer_needed ()) {
> -        qemu_mod_timer (s->ts, qemu_get_clock_ns (vm_clock) + 1);
> +        qemu_mod_timer (s->ts, qemu_get_clock_ns (vm_clock) +
> +                        conf.period.ticks);
>      }
>      else {
>          qemu_del_timer (s->ts);

Ah, thanks, this looks correct. Kept staring at 1.6/1.7 versions and wasn't
seeing a difference for some reason...

> =

> -- =

> Alex Bligh