From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo0P8-0005wC-6G for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:33:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vo0Oy-0006Zl-Ic for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:33:26 -0500 Received: from e32.co.us.ibm.com ([32.97.110.150]:57187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo0Oy-0006Y7-B9 for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:33:16 -0500 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Dec 2013 17:33:15 -0700 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id DCC3F19D8041 for ; Tue, 3 Dec 2013 17:33:06 -0700 (MST) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by b03cxnp08028.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rB3MVLHY34865316 for ; Tue, 3 Dec 2013 23:31:21 +0100 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id rB40aBfK008133 for ; Tue, 3 Dec 2013 17:36:12 -0700 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: References: <52794784.2020304@suse.de> Message-ID: <20131204003311.20090.1118@loki> Date: Tue, 03 Dec 2013 18:33:11 -0600 Subject: Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , =?utf-8?q?Andreas_F=C3=A4rber?= Cc: "patches@linaro.org" , qemu-devel , Anthony Liguori , Ken Moffat Quoting Peter Maydell (2013-11-05 13:36:57) > On 5 November 2013 19:31, Andreas F=C3=A4rber wrote: > > Am 05.11.2013 20:09, schrieb Peter Maydell: > >> I don't think there's any need to respin a patch > >> just because somebody thinks it might be worth > >> applying to stable. > > > > Point is, if you are ping'ing Anthony to apply this with his > > fully-automated patches tool, then he won't add the Cc and in turn it > > will unlikely be backported to 1.6.2. > > > > The response I got at QEMU Summit was that it is both the contributor's > > and the submaintainer's responsibility to add the Cc to the commit > > message. But maybe you're going to tell me that I misunderstood that as > > well... > = > I don't remember what people said particularly, but I don't > think our process for stable should rely on patch submitters > having to add cc tags and resend stuff because that's a > lot of faff for something most people don't care about. > Whoever is maintaining stable ought IMHO to be making their > own judgements about whether a fix is worth backporting > based on their criteria for what kind of fix to put in > that branch. I think the way to look at it is getting stuff applied is first priority, but if it's missing Cc: qemu-stable all bets are off on whether or not it gets pulled in for a stable release. Whether a contributor/maintainer cares enough to ensure this prior to commit is their call. That said, if it's CC'd *to* qemu-stable it'll generally get picked up. Maybe in the future if we find ourselves needing to automate things more that may not be the case though, so it's a good practice to adopt. In any case, ping? :) > = > -- PMM