From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo4oX-00028T-7N for qemu-devel@nongnu.org; Wed, 04 Dec 2013 00:16:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vo4oS-0003C2-70 for qemu-devel@nongnu.org; Wed, 04 Dec 2013 00:15:57 -0500 Received: from nodalink.pck.nerim.net ([62.212.105.220]:43623 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo4oR-0003Bo-Rb for qemu-devel@nongnu.org; Wed, 04 Dec 2013 00:15:52 -0500 Date: Wed, 4 Dec 2013 06:15:43 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20131204051543.GA2781@irqsave.net> References: <1386077165-19577-1-git-send-email-benoit@irqsave.net> <1386077165-19577-8-git-send-email-benoit@irqsave.net> <529EA6BE.5090403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <529EA6BE.5090403@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com Le Wednesday 04 Dec 2013 =C3=A0 11:51:26 (+0800), Fam Zheng a =C3=A9crit = : > On 2013=E5=B9=B412=E6=9C=8803=E6=97=A5 21:26, Beno=C3=AEt Canet wrote: > >Signed-off-by: Benoit Canet > >--- > > blockdev.c | 49 +++++++++++++++++++++++++++++++++++++++++-----= --- > > hmp.c | 4 +++- > > qapi-schema.json | 13 ++++++++++--- > > qmp-commands.hx | 11 ++++++++++- > > 4 files changed, 64 insertions(+), 13 deletions(-) > > > >diff --git a/blockdev.c b/blockdev.c > >index e314d62..68d4ad1 100644 > >--- a/blockdev.c > >+++ b/blockdev.c > >@@ -940,14 +940,22 @@ static void blockdev_do_action(int kind, void *d= ata, Error **errp) > > qmp_transaction(&list, errp); > > } > > > >-void qmp_blockdev_snapshot_sync(const char *device, const char *snaps= hot_file, > >- bool has_format, const char *format, > >- bool has_mode, enum NewImageMode mode= , > >- Error **errp) > >+void qmp_blockdev_snapshot_sync(bool has_device, const char * device, > >+ bool has_node_name, const char * node= _name, > >+ const char * snapshot_file, > >+ bool has_snapshot_node_name, > >+ const char * snapshot_node_name, > >+ bool has_format, const char * format, >=20 > Same question with some other function declarations and definitions > in this series: you are adding an extra whitespace between * and > pointer name, is it intended? No I copy/pasted qmp generated prototypes. Best regards Beno=C3=AEt >=20 > Thanks, > Fam >=20