From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, "Benoît Canet" <benoit.canet@irqsave.net>,
qemu-devel@nongnu.org, stefanha@redhat.com,
WenchaoXia <xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v6 5/6] qemu-iotests: Clean up spaces in usage output
Date: Wed, 4 Dec 2013 06:24:41 +0100 [thread overview]
Message-ID: <20131204052441.GD2781@irqsave.net> (raw)
In-Reply-To: <1386119223-15584-6-git-send-email-famz@redhat.com>
Le Wednesday 04 Dec 2013 à 09:07:02 (+0800), Fam Zheng a écrit :
> Whitespace changes to align columns.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/qemu-iotests/common | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
> index b2a0944..8b4e22c 100644
> --- a/tests/qemu-iotests/common
> +++ b/tests/qemu-iotests/common
> @@ -132,7 +132,7 @@ s/ .*//p
> echo "Usage: $0 [options] [testlist]"'
>
> common options
> - -v verbose
> + -v verbose
>
> check options
> -raw test raw (default)
> @@ -148,20 +148,20 @@ check options
> -sheepdog test sheepdog
> -nbd test nbd
> -ssh test ssh
> - -xdiff graphical mode diff
> - -nocache use O_DIRECT on backing file
> - -misalign misalign memory allocations
> - -n show me, do not run tests
> + -xdiff graphical mode diff
> + -nocache use O_DIRECT on backing file
> + -misalign misalign memory allocations
> + -n show me, do not run tests
> -o options -o options to pass to qemu-img create/convert
> - -T output timestamps
> - -r randomize test order
> + -T output timestamps
> + -r randomize test order
> -c mode cache mode
>
> testlist options
> -g group[,group...] include tests from these groups
> -x group[,group...] exclude tests from these groups
> NNN include test NNN
> - NNN-NNN include test range (eg. 012-021)
> + NNN-NNN include test range (eg. 012-021)
> '
> exit 0
> ;;
> --
> 1.8.4.2
>
First time I found a bug while reviewing !!
Reviewed-by: Benoit Canet <benoit@irqsave.net>
next prev parent reply other threads:[~2013-12-04 5:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 1:06 [Qemu-devel] [PATCH v6 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback" Fam Zheng
2013-12-04 1:06 ` [Qemu-devel] [PATCH v6 1/6] qemu-iotests: Add "-c <cache-mode>" option Fam Zheng
2013-12-04 1:06 ` [Qemu-devel] [PATCH v6 2/6] qemu-iotests: Honour cache mode in iotests.py Fam Zheng
2013-12-04 1:07 ` [Qemu-devel] [PATCH v6 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes Fam Zheng
2013-12-04 1:07 ` [Qemu-devel] [PATCH v6 4/6] qemu-iotests: Change default cache mode to "writeback" Fam Zheng
2013-12-04 1:07 ` [Qemu-devel] [PATCH v6 5/6] qemu-iotests: Clean up spaces in usage output Fam Zheng
2013-12-04 5:24 ` Benoît Canet [this message]
2013-12-04 1:07 ` [Qemu-devel] [PATCH v6 6/6] qemu-iotests: Split qcow2 only cases in 048 Fam Zheng
2013-12-04 12:45 ` [Qemu-devel] [PATCH] qemu-iotests: 074 fixups Stefan Hajnoczi
2013-12-04 12:52 ` Fam Zheng
2013-12-04 13:30 ` [Qemu-devel] [PATCH v6 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback" Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204052441.GD2781@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).