From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo9iH-0001pg-M7 for qemu-devel@nongnu.org; Wed, 04 Dec 2013 05:29:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vo9iC-0000a3-Tz for qemu-devel@nongnu.org; Wed, 04 Dec 2013 05:29:49 -0500 Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:48708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vo9iC-0000Zr-Iy for qemu-devel@nongnu.org; Wed, 04 Dec 2013 05:29:44 -0500 Received: by mail-ee0-f52.google.com with SMTP id d17so2031260eek.25 for ; Wed, 04 Dec 2013 02:29:43 -0800 (PST) Date: Wed, 4 Dec 2013 11:29:40 +0100 From: Stefan Hajnoczi Message-ID: <20131204102940.GA21609@stefanha-thinkpad.redhat.com> References: <1386151596-32411-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386151596-32411-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qcow2: Zero-initialise first cluster for new images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Wed, Dec 04, 2013 at 11:06:36AM +0100, Kevin Wolf wrote: > Strictly speaking, this is only required for has_zero_init() == false, > but it's easy enough to just do a cluster-aligned write that is padded > with zeros after the header. > > This fixes that after 'qemu-img create' header extensions are attempted > to be parsed that are really just random leftover data. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Kevin Wolf > Reviewed-by: Fam Zheng > Reviewed-by: Paolo Bonzini > --- > block/qcow2.c | 36 ++++++++++++++++++++---------------- > 1 file changed, 20 insertions(+), 16 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan