From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCHv3 1.8 7/9] qemu-img: round down request length to an aligned sector
Date: Wed, 4 Dec 2013 16:49:04 +0100 [thread overview]
Message-ID: <20131204154904.GD27759@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1385546829-3839-8-git-send-email-pl@kamp.de>
On Wed, Nov 27, 2013 at 11:07:07AM +0100, Peter Lieven wrote:
> @@ -1397,19 +1396,21 @@ static int img_convert(int argc, char **argv)
> }
> }
>
> + cluster_sectors = 0;
> + ret = bdrv_get_info(out_bs, &bdi);
> + if (ret < 0 && compress) {
> + error_report("could not get block driver info");
> + goto out;
> + } else {
> + cluster_sectors = bdi.cluster_size / BDRV_SECTOR_SIZE;
> + }
Why do we only report error if 'compress' is set? cluster_sectors must
be valid and we cannot guarantee that if bdrv_get_info() failed.
next prev parent reply other threads:[~2013-12-04 15:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 10:07 [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert Peter Lieven
2013-11-27 10:17 ` Paolo Bonzini
2013-12-04 16:46 ` Stefan Hajnoczi
2013-12-04 16:51 ` Peter Lieven
2013-12-05 10:30 ` Stefan Hajnoczi
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 2/9] qemu-img: fix usage instruction for qemu-img convert Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 3/9] block/iscsi: set bdi->cluster_size Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 4/9] block: add opt_transfer_length to BlockLimits Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 5/9] block/iscsi: set bs->bl.opt_transfer_length Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 6/9] qemu-img: dynamically adjust iobuffer size during convert Peter Lieven
2013-12-05 13:30 ` Eric Blake
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 7/9] qemu-img: round down request length to an aligned sector Peter Lieven
2013-12-04 15:49 ` Stefan Hajnoczi [this message]
2013-12-04 15:56 ` Peter Lieven
2013-12-05 10:33 ` Stefan Hajnoczi
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 8/9] qemu-img: increase min_sparse to 128 sectors (64kb) Peter Lieven
2013-12-04 16:43 ` Stefan Hajnoczi
2013-12-04 16:46 ` Peter Lieven
2013-12-05 2:12 ` Eric Blake
2013-12-05 4:55 ` Peter Lieven
2013-12-05 10:35 ` Stefan Hajnoczi
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 9/9] qemu-img: decrease progress update interval on convert Peter Lieven
2013-12-05 12:15 ` [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations Stefan Hajnoczi
2013-12-05 14:55 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204154904.GD27759@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).