From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VoEhR-0006id-En
	for qemu-devel@nongnu.org; Wed, 04 Dec 2013 10:49:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VoEhI-0001m8-Ae
	for qemu-devel@nongnu.org; Wed, 04 Dec 2013 10:49:17 -0500
Received: from mail-ea0-x22d.google.com ([2a00:1450:4013:c01::22d]:65189)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VoEhI-0001m4-3k
	for qemu-devel@nongnu.org; Wed, 04 Dec 2013 10:49:08 -0500
Received: by mail-ea0-f173.google.com with SMTP id g15so10760031eak.18
	for <qemu-devel@nongnu.org>; Wed, 04 Dec 2013 07:49:07 -0800 (PST)
Date: Wed, 4 Dec 2013 16:49:04 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131204154904.GD27759@stefanha-thinkpad.redhat.com>
References: <1385546829-3839-1-git-send-email-pl@kamp.de>
	<1385546829-3839-8-git-send-email-pl@kamp.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1385546829-3839-8-git-send-email-pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCHv3 1.8 7/9] qemu-img: round down request
 length to an aligned sector
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Nov 27, 2013 at 11:07:07AM +0100, Peter Lieven wrote:
> @@ -1397,19 +1396,21 @@ static int img_convert(int argc, char **argv)
>          }
>      }
>  
> +    cluster_sectors = 0;
> +    ret = bdrv_get_info(out_bs, &bdi);
> +    if (ret < 0 && compress) {
> +        error_report("could not get block driver info");
> +        goto out;
> +    } else {
> +        cluster_sectors = bdi.cluster_size / BDRV_SECTOR_SIZE;
> +    }

Why do we only report error if 'compress' is set?  cluster_sectors must
be valid and we cannot guarantee that if bdrv_get_info() failed.