From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52969)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1VoWaY-0005GE-As
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 05:55:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1VoWaP-0001Bj-69
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 05:55:22 -0500
Received: from e23smtp01.au.ibm.com ([202.81.31.143]:48985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1VoWaO-0001Az-DO
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 05:55:13 -0500
Received: from /spool/local
	by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <bharata@linux.vnet.ibm.com>;
	Thu, 5 Dec 2013 20:54:47 +1000
Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120])
	by d23dlp03.au.ibm.com (Postfix) with ESMTP id 09AA935780AE
	for <qemu-devel@nongnu.org>; Thu,  5 Dec 2013 21:43:38 +1100 (EST)
Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	rB5APWnk65339434
	for <qemu-devel@nongnu.org>; Thu, 5 Dec 2013 21:25:32 +1100
Received: from d23av02.au.ibm.com (localhost [127.0.0.1])
	by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	rB5AhbKj001498
	for <qemu-devel@nongnu.org>; Thu, 5 Dec 2013 21:43:37 +1100
Date: Thu, 5 Dec 2013 16:15:02 +0530
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Message-ID: <20131205104502.GB21197@in.ibm.com>
References: <1385104578-19369-1-git-send-email-bharata@linux.vnet.ibm.com>
	<1385104578-19369-3-git-send-email-bharata@linux.vnet.ibm.com>
	<20131204191628.GD3780@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131204191628.GD3780@localhost.localdomain>
Subject: Re: [Qemu-devel] [RFC PATCH v0 2/3] gluster: Implement
 .bdrv_co_write_zeroes for gluster
Reply-To: bharata@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Dec 04, 2013 at 02:16:28PM -0500, Jeff Cody wrote:
> On Fri, Nov 22, 2013 at 12:46:17PM +0530, Bharata B Rao wrote:
> > +
> > +    ret = glfs_zerofill_async(s->fd, offset, size, &gluster_finish_aiocb, acb);
> > +    if (ret < 0) {
> 
> I believe glfs_zerofill_async returns -1 on failure, and sets errno.
> In that case, we should set ret = -errno here.

This needs to be done for other routines too. Will address this and the
other comment you have given in 2/3 thread. Thanks.

Regards,
Bharata.