From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Eric Blake <eblake@redhat.com>
Cc: "Benoît Canet" <benoit.canet@irqsave.net>,
kwolf@redhat.com, famz@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph.
Date: Thu, 5 Dec 2013 17:37:36 +0100 [thread overview]
Message-ID: <20131205163735.GG2892@irqsave.net> (raw)
In-Reply-To: <52A094CA.7050106@redhat.com>
Le Thursday 05 Dec 2013 à 07:59:22 (-0700), Eric Blake a écrit :
> On 12/05/2013 07:43 AM, Benoît Canet wrote:
>
> >> There's one case where management might not know - if libvirtd gets
> >> restarted while in the middle of an operation that was attempting to
> >> create a named node, then on restart and reconnection to the monitor,
> >> libvirt would want to query to see if the node actually got created or
> >> if the command needs to be attempted again. I'm not a fan of write-only
> >> interfaces - and making management responsible to track all named nodes
> >> with no way to query if qemu actually agrees with the topology that
> >> management thinks it has commanded feels like a write-only interface.
> >
> > Would a command returning info about a specific named node be sufficient for
> > libvirt checks ?
> > It's far less complex to implement than exposing the whole graph.
> > We could also provide a simple command to list the names of the named nodes.
>
> Yes, both of those ideas are useful; it still means management must
> track the topology between the nodes, but it at least gives management
> enough control to know which set of nodes exist to confirm which
> operations have occurred.
I will start by implementing the named nodes name list first.
Don't worry for the other solution: my customer want crypto filters and multi
BlockDriver state throttling as a filter so I will continue to enable filter
in a progressive way.
Best regards
Benoît
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
next prev parent reply other threads:[~2013-12-05 16:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 13:25 [Qemu-devel] [RFC V3 0/7] Giving names to BlockDriverState graph nodes Benoît Canet
2013-12-03 13:25 ` [Qemu-devel] [RFC V3 1/7] block: Add bs->node_name to hold the name of a bs node of the bs graph Benoît Canet
2013-12-04 23:26 ` Eric Blake
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 2/7] block: Allow the user to define "node-name" option Benoît Canet
2013-12-04 23:33 ` Eric Blake
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph Benoît Canet
2013-12-04 3:10 ` Fam Zheng
2013-12-04 23:46 ` Eric Blake
2013-12-05 14:24 ` Benoît Canet
2013-12-05 14:38 ` Eric Blake
2013-12-05 14:43 ` Benoît Canet
2013-12-05 14:59 ` Eric Blake
2013-12-05 16:37 ` Benoît Canet [this message]
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 4/7] qmp: Allow block_passwd to manipulate bs graph nodes Benoît Canet
2013-12-04 23:56 ` Eric Blake
2013-12-05 14:12 ` Benoît Canet
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 5/7] qmp: Allow block_resize " Benoît Canet
2013-12-05 0:01 ` Eric Blake
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots Benoît Canet
2013-12-04 3:35 ` Fam Zheng
2013-12-04 5:22 ` Benoît Canet
2013-12-04 3:47 ` Fam Zheng
2013-12-04 5:20 ` Benoît Canet
2013-12-04 6:12 ` Fam Zheng
2013-12-04 6:34 ` Benoît Canet
2013-12-04 7:03 ` Fam Zheng
2013-12-05 14:52 ` Benoît Canet
2013-12-03 13:26 ` [Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node Benoît Canet
2013-12-04 3:51 ` Fam Zheng
2013-12-04 5:15 ` Benoît Canet
2013-12-05 0:11 ` Eric Blake
2013-12-05 14:16 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205163735.GG2892@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).