From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VockZ-00034n-F4 for qemu-devel@nongnu.org; Thu, 05 Dec 2013 12:30:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VockQ-0005HH-E4 for qemu-devel@nongnu.org; Thu, 05 Dec 2013 12:30:07 -0500 Received: from e9.ny.us.ibm.com ([32.97.182.139]:52372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VockQ-0005H9-85 for qemu-devel@nongnu.org; Thu, 05 Dec 2013 12:29:58 -0500 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Dec 2013 12:29:57 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <529FE537.1080206@ozlabs.ru> References: <1386206394-21092-1-git-send-email-mdroth@linux.vnet.ibm.com> <1386206394-21092-8-git-send-email-mdroth@linux.vnet.ibm.com> <529FE537.1080206@ozlabs.ru> Message-ID: <20131205172953.5523.24006@loki> Date: Thu, 05 Dec 2013 11:29:53 -0600 Subject: Re: [Qemu-devel] [PATCH 07/14] spapr: add helper to retrieve a PHB/device DrcEntry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: agraf@suse.de, ncmike@ncultra.org, paulus@samba.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, qemu-ppc@nongnu.org Quoting Alexey Kardashevskiy (2013-12-04 20:30:15) > On 12/05/2013 12:19 PM, Michael Roth wrote: > > Signed-off-by: Michael Roth > > --- > > hw/ppc/spapr.c | 36 ++++++++++++++++++++++++++++++++++++ > > include/hw/ppc/spapr.h | 2 ++ > > 2 files changed, 38 insertions(+) > > = > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index 0607559..2250ee1 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -277,6 +277,42 @@ static size_t create_page_sizes_prop(CPUPPCState *= env, uint32_t *prop, > > return (p - prop) * sizeof(uint32_t); > > } > > = > > +DrcEntry *spapr_phb_to_drc_entry(uint64_t buid) > > +{ > > + int i; > > + > > + for (i =3D 0; i < SPAPR_DRC_TABLE_SIZE; i++) { > > + if (drc_table[i].phb_buid =3D=3D buid) { > > + return &drc_table[i]; > > + } > > + } > > + > > + return NULL; > > +} > > + > > +DrcEntry *spapr_find_drc_entry(int drc_index) > > +{ > > + int i, j; > > + > > + for (i =3D 0; i < SPAPR_DRC_TABLE_SIZE; i++) { > > + DrcEntry *phb_entry =3D &drc_table[i]; > > + if (phb_entry->drc_index =3D=3D drc_index) { > > + return phb_entry; > > + } > > + if (phb_entry->child_entries =3D=3D NULL) { > > + continue; > > + } > > + for (j =3D 0; j < SPAPR_DRC_PHB_SLOT_MAX; j++) { > > + DrcEntry *entry =3D &phb_entry->child_entries[j]; > > + if (entry->drc_index =3D=3D drc_index) { > > + return entry; > > + } > > + } > > + } > > + > > + return NULL; > > +} > = > = > spapr_find_drc_entry() is used in patches 1/3/4 but defined only in 7th > patch, so patches 1..6 won't compile which breaks bisect. Sorry, I messed this up re-organizing the patches. Will fix and re-test for v2. > = > = > = > = > -- = > Alexey