From: Amit Shah <amit.shah@redhat.com>
To: Gal Hammer <ghammer@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] char: restore read callback on a reattached (hotplug) chardev
Date: Fri, 6 Dec 2013 12:22:48 +0530 [thread overview]
Message-ID: <20131206065248.GC24076@grmbl.mre> (raw)
In-Reply-To: <1385366860-14010-1-git-send-email-ghammer@redhat.com>
Hi,
On (Mon) 25 Nov 2013 [10:07:40], Gal Hammer wrote:
> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
> set the chr handlers to NULL. However when the device is plugged back,
> its read callback is not restored so data can't be transfter from the
> host to the guest via the virtio-serial port.
Yes, good catch.
That commit removes the callback for all backend types, but this
commit only takes care of tcp. Can you check the others too? There
are a couple of backends which even remove their callback in the
update_read_handler() function, which may result in a double-free.
Can you look at that too?
Thanks,
Amit
prev parent reply other threads:[~2013-12-06 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 8:07 [Qemu-devel] [PATCH] char: restore read callback on a reattached (hotplug) chardev Gal Hammer
2013-12-01 7:53 ` Gal Hammer
2013-12-06 6:52 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206065248.GC24076@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=ghammer@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).