From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46489)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1VopHW-0007ba-EP
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 01:53:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1VopHQ-0002vK-9O
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 01:52:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22382)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1VopHQ-0002vA-13
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 01:52:52 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB66qoIq021460
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 6 Dec 2013 01:52:50 -0500
Date: Fri, 6 Dec 2013 12:22:48 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20131206065248.GC24076@grmbl.mre>
References: <1385366860-14010-1-git-send-email-ghammer@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1385366860-14010-1-git-send-email-ghammer@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] char: restore read callback on a
 reattached (hotplug) chardev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gal Hammer <ghammer@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Hi,

On (Mon) 25 Nov 2013 [10:07:40], Gal Hammer wrote:
> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
> set the chr handlers to NULL. However when the device is plugged back,
> its read callback is not restored so data can't be transfter from the
> host to the guest via the virtio-serial port.

Yes, good catch.

That commit removes the callback for all backend types, but this
commit only takes care of tcp.  Can you check the others too?  There
are a couple of backends which even remove their callback in the
update_read_handler() function, which may result in a double-free.

Can you look at that too?

Thanks,

		Amit