From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Liu Jinsong <jinsong.liu@intel.com>,
kvm@vger.kernel.org, x86@kernel.org,
Xudong Hao <xudong.hao@intel.com>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
Ingo Molnar <mingo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Qiaowei Ren <qiaowei.ren@intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Qemu-devel] [PATCH 3/3] X86, mpx: Intel MPX xstate feature definition
Date: Fri, 6 Dec 2013 19:55:34 +0100 [thread overview]
Message-ID: <20131206185534.GA7528@pd.tnic> (raw)
In-Reply-To: <52A2080A.9010208@zytor.com>
On Fri, Dec 06, 2013 at 09:23:22AM -0800, H. Peter Anvin wrote:
> On 12/06/2013 05:46 AM, Borislav Petkov wrote:
> > I'm guessing this and the struct lwp_struct above is being added so that
> > you can have the LWP XSAVE area size? If so, you don't need it: LWP
> > XSAVE area is 128 bytes at offset 832 according to my manuals so I'd
> > guess having a u8 lwp_area[128] should be fine.
> >
> Sure, but any reason to *not* document the internal structure?
Only that you might start getting remove-this-unused-struct patches. :-)
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
prev parent reply other threads:[~2013-12-06 18:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 18:52 [Qemu-devel] [PATCH 1/3] x86, mpx: add documentation on Intel MPX Qiaowei Ren
2013-12-06 13:26 ` Borislav Petkov
2013-12-06 15:55 ` Ren, Qiaowei
2013-12-06 16:06 ` Borislav Petkov
2013-12-06 16:11 ` Ren, Qiaowei
2013-12-06 18:52 ` [Qemu-devel] [PATCH 2/3] X86, mpx: Intel MPX definition Qiaowei Ren
2013-12-06 13:33 ` Borislav Petkov
2013-12-06 15:58 ` H. Peter Anvin
2013-12-06 18:52 ` [Qemu-devel] [PATCH 3/3] X86, mpx: Intel MPX xstate feature definition Qiaowei Ren
2013-12-06 13:46 ` Borislav Petkov
2013-12-06 16:08 ` Ren, Qiaowei
2013-12-06 17:23 ` H. Peter Anvin
2013-12-06 18:55 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206185534.GA7528@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jinsong.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qiaowei.ren@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).