From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp0Yz-0000J0-Qs for qemu-devel@nongnu.org; Fri, 06 Dec 2013 13:55:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vp0Yt-0007tg-IB for qemu-devel@nongnu.org; Fri, 06 Dec 2013 13:55:45 -0500 Received: from mail.skyhub.de ([2a01:4f8:120:8448::d00d]:38792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp0Yt-0007tV-8M for qemu-devel@nongnu.org; Fri, 06 Dec 2013 13:55:39 -0500 Date: Fri, 6 Dec 2013 19:55:34 +0100 From: Borislav Petkov Message-ID: <20131206185534.GA7528@pd.tnic> References: <1386355976-11732-1-git-send-email-qiaowei.ren@intel.com> <1386355976-11732-3-git-send-email-qiaowei.ren@intel.com> <20131206134631.GD6694@pd.tnic> <52A2080A.9010208@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <52A2080A.9010208@zytor.com> Subject: Re: [Qemu-devel] [PATCH 3/3] X86, mpx: Intel MPX xstate feature definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "H. Peter Anvin" Cc: Liu Jinsong , kvm@vger.kernel.org, x86@kernel.org, Xudong Hao , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, Ingo Molnar , Paolo Bonzini , Qiaowei Ren , Thomas Gleixner On Fri, Dec 06, 2013 at 09:23:22AM -0800, H. Peter Anvin wrote: > On 12/06/2013 05:46 AM, Borislav Petkov wrote: > > I'm guessing this and the struct lwp_struct above is being added so that > > you can have the LWP XSAVE area size? If so, you don't need it: LWP > > XSAVE area is 128 bytes at offset 832 according to my manuals so I'd > > guess having a u8 lwp_area[128] should be fine. > > > Sure, but any reason to *not* document the internal structure? Only that you might start getting remove-this-unused-struct patches. :-) -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --