From: Antony Pavlov <antonynpavlov@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Dmitry Smagin <dmitry.s.smagin@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] eeprom93xx: fix coding style
Date: Sat, 7 Dec 2013 05:14:09 +0400 [thread overview]
Message-ID: <20131207051409.778325ede8e97cf719214ac2@gmail.com> (raw)
In-Reply-To: <52A21E91.7070404@msgid.tls.msk.ru>
On Fri, 06 Dec 2013 22:59:29 +0400
Michael Tokarev <mjt@tls.msk.ru> wrote:
> 04.12.2013 10:27, Antony Pavlov wrote:
> > scripts/checkpatch.pl reports about some style problems,
> > this commit fixes some of them:
>
> Thanks, applied to trivial-patches queue.
>
> I'm a bit afraid of this sort of patches - there are LOTS of
> coding style issues in current qemu code base, and applying
> a patch like this may open a really large can of worms...
>
> Generally it has been agreed to fix coding style only when
> doing some other code changes nearby, as far as I remember.
Some times ago there was a patch on adding DEC Tulip NIC support
(see http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02878.html).
In this patch the 93LC46B Serial EEPROM emulation was added.
But it's like reinventing the wheel because Stefan Weil already
have done this work in 2006! So I used eeprom93xx for the next
tulip patch version and occasionally I fixed some coding style issues.
--
Best regards,
Antony Pavlov
prev parent reply other threads:[~2013-12-07 1:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 6:27 [Qemu-devel] [PATCH] eeprom93xx: fix coding style Antony Pavlov
2013-12-04 6:29 ` Stefan Weil
2013-12-06 18:59 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-12-07 1:14 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131207051409.778325ede8e97cf719214ac2@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=dmitry.s.smagin@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).