From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp6M7-0005bj-5t for qemu-devel@nongnu.org; Fri, 06 Dec 2013 20:06:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vp6M2-0004Kf-U6 for qemu-devel@nongnu.org; Fri, 06 Dec 2013 20:06:51 -0500 Date: Sat, 7 Dec 2013 05:14:09 +0400 From: Antony Pavlov Message-Id: <20131207051409.778325ede8e97cf719214ac2@gmail.com> In-Reply-To: <52A21E91.7070404@msgid.tls.msk.ru> References: <1386138449-1235-1-git-send-email-antonynpavlov@gmail.com> <52A21E91.7070404@msgid.tls.msk.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] eeprom93xx: fix coding style List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, Stefan Weil , qemu-devel@nongnu.org, Dmitry Smagin On Fri, 06 Dec 2013 22:59:29 +0400 Michael Tokarev wrote: > 04.12.2013 10:27, Antony Pavlov wrote: > > scripts/checkpatch.pl reports about some style problems, > > this commit fixes some of them: >=20 > Thanks, applied to trivial-patches queue. >=20 > I'm a bit afraid of this sort of patches - there are LOTS of > coding style issues in current qemu code base, and applying > a patch like this may open a really large can of worms... >=20 > Generally it has been agreed to fix coding style only when > doing some other code changes nearby, as far as I remember. Some times ago there was a patch on adding DEC Tulip NIC support (see http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02878.html). In this patch the 93LC46B Serial EEPROM emulation was added. But it's like reinventing the wheel because Stefan Weil already have done this work in 2006! So I used eeprom93xx for the next tulip patch version and occasionally I fixed some coding style issues. --=A0 Best regards, =A0 Antony Pavlov