From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpcWv-0005w3-6D for qemu-devel@nongnu.org; Sun, 08 Dec 2013 06:28:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VpcWo-0002y5-7C for qemu-devel@nongnu.org; Sun, 08 Dec 2013 06:28:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpcWn-0002vU-Uo for qemu-devel@nongnu.org; Sun, 08 Dec 2013 06:28:02 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB8BS0YC011028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 8 Dec 2013 06:28:00 -0500 Date: Sun, 8 Dec 2013 13:31:38 +0200 From: "Michael S. Tsirkin" Message-ID: <20131208113138.GC6841@redhat.com> References: <1386329080-28836-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386329080-28836-1-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH] pci: fix pci bridge fw path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Marcel Apfelbaum On Fri, Dec 06, 2013 at 12:24:40PM +0100, Gerd Hoffmann wrote: > qemu uses "pci" as name for pci bridges in the firmware device path. > seabios expects "pci-bridge". Result is that bootorder is broken for > devices behind pci bridges. > > Some googling suggests that "pci-bridge" is the correct one. At least > PPC-based Apple machines are using this. See question "How do I boot > from a device attached to a PCI card" here: > http://www.netbsd.org/ports/macppc/faq.html > > So lets change qemu to use "pci-bridge" too. > > Signed-off-by: Gerd Hoffmann Sounds good but this needs to be enabled for new machine types only - otherwise guest will read corrupted data since bootindex is in FW CFG. Alternatively, extend 04920fc0faa4760f9c4fc0e73b992b768099be70 to work for all fw cfg file entries. I think the whole boot index thing needs to be reworked: we also have the long-standing feature request to allow booting from a device added by hot add. > --- > hw/pci/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 49eca95..82c11ec 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -1330,7 +1330,7 @@ static const pci_class_desc pci_class_descriptions[] = > { 0x0601, "ISA bridge", "isa"}, > { 0x0602, "EISA bridge", "eisa"}, > { 0x0603, "MC bridge", "mca"}, > - { 0x0604, "PCI bridge", "pci"}, > + { 0x0604, "PCI bridge", "pci-bridge"}, > { 0x0605, "PCMCIA bridge", "pcmcia"}, > { 0x0606, "NUBUS bridge", "nubus"}, > { 0x0607, "CARDBUS bridge", "cardbus"}, > -- > 1.8.3.1