From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59636)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Vpf4l-0008NM-7B
	for qemu-devel@nongnu.org; Sun, 08 Dec 2013 09:11:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Vpf4f-00068D-Af
	for qemu-devel@nongnu.org; Sun, 08 Dec 2013 09:11:15 -0500
Received: from mail-pb0-x233.google.com ([2607:f8b0:400e:c01::233]:33474)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Vpf4f-000687-2a
	for qemu-devel@nongnu.org; Sun, 08 Dec 2013 09:11:09 -0500
Received: by mail-pb0-f51.google.com with SMTP id up15so3774605pbc.24
	for <qemu-devel@nongnu.org>; Sun, 08 Dec 2013 06:11:07 -0800 (PST)
Date: Sun, 8 Dec 2013 15:10:52 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20131208141052.GC3738@zapo>
References: <1386381154-29682-1-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1386381154-29682-1-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] target-cris: Use new qemu_ld/st opcodes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Sat, Dec 07, 2013 at 02:52:34PM +1300, Richard Henderson wrote:
> Using the new opcodes we can reduce if/else trees to
> a single statement.

I committed this, thanks.

Edgar


> 
> Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-cris/translate.c | 29 ++++-------------------------
>  1 file changed, 4 insertions(+), 25 deletions(-)
> 
> diff --git a/target-cris/translate.c b/target-cris/translate.c
> index 5faa44c..f990d59 100644
> --- a/target-cris/translate.c
> +++ b/target-cris/translate.c
> @@ -1133,7 +1133,7 @@ static void gen_load64(DisasContext *dc, TCGv_i64 dst, TCGv addr)
>          cris_store_direct_jmp(dc);
>      }
>  
> -    tcg_gen_qemu_ld64(dst, addr, mem_index);
> +    tcg_gen_qemu_ld_i64(dst, addr, mem_index, MO_TEQ);
>  }
>  
>  static void gen_load(DisasContext *dc, TCGv dst, TCGv addr, 
> @@ -1147,23 +1147,8 @@ static void gen_load(DisasContext *dc, TCGv dst, TCGv addr,
>          cris_store_direct_jmp(dc);
>      }
>  
> -    if (size == 1) {
> -        if (sign) {
> -            tcg_gen_qemu_ld8s(dst, addr, mem_index);
> -        } else {
> -            tcg_gen_qemu_ld8u(dst, addr, mem_index);
> -        }
> -    } else if (size == 2) {
> -        if (sign) {
> -            tcg_gen_qemu_ld16s(dst, addr, mem_index);
> -        } else {
> -            tcg_gen_qemu_ld16u(dst, addr, mem_index);
> -        }
> -    } else if (size == 4) {
> -        tcg_gen_qemu_ld32u(dst, addr, mem_index);
> -    } else {
> -        abort();
> -    }
> +    tcg_gen_qemu_ld_tl(dst, addr, mem_index,
> +                       MO_TE + ctz32(size) + (sign ? MO_SIGN : 0));
>  }
>  
>  static void gen_store (DisasContext *dc, TCGv addr, TCGv val,
> @@ -1187,13 +1172,7 @@ static void gen_store (DisasContext *dc, TCGv addr, TCGv val,
>          return;
>      }
>  
> -    if (size == 1) {
> -        tcg_gen_qemu_st8(val, addr, mem_index);
> -    } else if (size == 2) {
> -        tcg_gen_qemu_st16(val, addr, mem_index);
> -    } else {
> -        tcg_gen_qemu_st32(val, addr, mem_index);
> -    }
> +    tcg_gen_qemu_st_tl(val, addr, mem_index, MO_TE + ctz32(size));
>  
>      if (dc->flagx_known && dc->flags_x) {
>          cris_evaluate_flags(dc);
> -- 
> 1.8.3.1
>