From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vpy1p-0000g8-91 for qemu-devel@nongnu.org; Mon, 09 Dec 2013 05:25:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vpy1j-0003E3-Kp for qemu-devel@nongnu.org; Mon, 09 Dec 2013 05:25:29 -0500 Received: from mga01.intel.com ([192.55.52.88]:51200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vpy1j-0003D6-G0 for qemu-devel@nongnu.org; Mon, 09 Dec 2013 05:25:23 -0500 From: "Kirill A. Shutemov" In-Reply-To: <1385726178-10201-1-git-send-email-kirill.shutemov@linux.intel.com> References: <1385726178-10201-1-git-send-email-kirill.shutemov@linux.intel.com> Content-Transfer-Encoding: 7bit Message-Id: <20131209102517.33F4EE0090@blue.fi.intel.com> Date: Mon, 9 Dec 2013 12:25:17 +0200 (EET) Subject: Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Kirill A. Shutemov" Cc: qemu-devel@nongnu.org, aliguori@amazon.com, aneesh.kumar@linux.vnet.ibm.com Kirill A. Shutemov wrote: > Currently we have few issues with P9_STATS_GEN: > > - We don't try to read st_gen anything except files or directories, but > still set P9_STATS_GEN bit in st_result_mask. It may mislead client: > we present garbage as valid st_gen. > > - If we failed to get valid st_gen with ENOTTY, we ignore error, but > still set P9_STATS_GEN bit in st_result_mask. > > - If we failed to get valid st_gen with any other errno, we fail > getattr altogether. It's excessive: we block valid client use-cases, > like chdir(2) to non-readable directory with execution bit set. > > The patch fixes these issues and cleanup code a bit. > > Signed-off-by: Kirill A. Shutemov > Reviewed-by: Daniel P. Berrange > Reviewed-by: Aneesh Kumar K.V Ping? -- Kirill A. Shutemov