From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41727)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1VpzRE-000446-Ke
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 06:55:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1VpzR8-0004wb-GG
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 06:55:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27281)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1VpzR8-0004wT-6M
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 06:55:42 -0500
Date: Mon, 9 Dec 2013 19:55:36 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20131209115536.GC13283@amosk.info>
References: <1386576358-10469-1-git-send-email-akong@redhat.com>
	<1386576358-10469-2-git-send-email-akong@redhat.com>
	<878uvufkp5.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <878uvufkp5.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] fix a typo of strict option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws

On Mon, Dec 09, 2013 at 10:16:38AM +0100, Markus Armbruster wrote:
> Amos Kong <akong@redhat.com> writes:
> 
> > The type of "strict" should be bool.
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
> > ---
> >  vl.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/vl.c b/vl.c
> > index b0399de..12fe1f7 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -461,7 +461,7 @@ static QemuOptsList qemu_boot_opts = {
> >              .type = QEMU_OPT_STRING,
> >          }, {
> >              .name = "strict",
> > -            .type = QEMU_OPT_STRING,
> > +            .type = QEMU_OPT_BOOL,
> >          },
> >          { /*End of list */ }
> >      },
> 
> No, this isn't just a typo fix, it's an interface change.  It's not
> immediately obvious whether it's okay.
 
You are correct, it's not a typo, menu's type was also changed from STRING to BOOL.
We can just process strict as menu.

> -boot parameter 'strict' appeared in commit c8a6ae8.  It was declared
> QEMU_OPT_STRING, but the code using the value rejected anything but 'on'
> and 'off'.  This shipped in 1.5.0.
> 
> Commit 6ef4716 accidentally dropped the code using the value of
> 'strict'.  Since then, any parameter value is accepted and silently
> ignored.  Shipped in 1.6.0.
> 
> Your change restores the "reject anything but 'on' and 'off'" part (the
> "use the value" part gets restored in the next patch).  Okay, because
> the values erroneously accepted in the meantime didn't do anything.

Thanks your explanation :)

-- 
			Amos.