From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq05A-00030M-7A for qemu-devel@nongnu.org; Mon, 09 Dec 2013 07:37:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vq054-0008Qc-Rv for qemu-devel@nongnu.org; Mon, 09 Dec 2013 07:37:04 -0500 Received: from mail-ea0-x22e.google.com ([2a00:1450:4013:c01::22e]:65226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq054-0008QX-Lu for qemu-devel@nongnu.org; Mon, 09 Dec 2013 07:36:58 -0500 Received: by mail-ea0-f174.google.com with SMTP id b10so1530625eae.33 for ; Mon, 09 Dec 2013 04:36:57 -0800 (PST) Date: Mon, 9 Dec 2013 13:36:54 +0100 From: Stefan Hajnoczi Message-ID: <20131209123654.GB9611@stefanha-thinkpad.redhat.com> References: <1386341073-6584-1-git-send-email-v.maffione@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386341073-6584-1-git-send-email-v.maffione@gmail.com> Subject: Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincenzo Maffione Cc: peter.maydell@linaro.org, mst@redhat.com, jasowang@redhat.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, peter.crosthwaite@petalogix.com, owasserm@redhat.com, kraxel@redhat.com, yan@daynix.com, edgar.iglesias@gmail.com, akong@redhat.com, quintela@redhat.com, agraf@suse.de, aliguori@amazon.com, marcel.a@redhat.com, sw@weilnetz.de, stefanha@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it, dmitry@daynix.com, mark.langsdorf@calxeda.com, pbonzini@redhat.com, afaerber@suse.de On Fri, Dec 06, 2013 at 03:44:33PM +0100, Vincenzo Maffione wrote: > - This patch is against the net-next tree (https://github.com/stefanha/qemu.git) > because the first netmap patch is not in the qemu master (AFAIK). You are right. I am sending a pull request now to get those patches into qemu.git/master. > hw/net/cadence_gem.c | 3 ++- > hw/net/dp8393x.c | 5 +++-- > hw/net/e1000.c | 21 ++++++++++++++++----- > hw/net/eepro100.c | 5 +++-- > hw/net/etraxfs_eth.c | 5 +++-- > hw/net/lan9118.c | 2 +- > hw/net/mcf_fec.c | 5 +++-- > hw/net/mipsnet.c | 6 ++++-- > hw/net/ne2000.c | 5 +++-- > hw/net/ne2000.h | 3 ++- > hw/net/opencores_eth.c | 2 +- > hw/net/pcnet.c | 8 +++++--- > hw/net/pcnet.h | 3 ++- > hw/net/rtl8139.c | 7 ++++--- > hw/net/smc91c111.c | 5 +++-- > hw/net/spapr_llan.c | 2 +- > hw/net/stellaris_enet.c | 3 ++- > hw/net/virtio-net.c | 10 ++++++++-- > hw/net/vmxnet3.c | 3 ++- > hw/net/vmxnet_tx_pkt.c | 4 ++-- > hw/net/xgmac.c | 2 +- > hw/net/xilinx_axienet.c | 2 +- > hw/usb/dev-network.c | 8 +++++--- > include/net/net.h | 20 +++++++++++++------- > include/net/queue.h | 1 + > net/dump.c | 3 ++- > net/hub.c | 10 ++++++---- > net/net.c | 39 +++++++++++++++++++++++---------------- > net/netmap.c | 17 ++++++++++++----- > net/slirp.c | 5 +++-- > net/socket.c | 10 ++++++---- > net/tap-win32.c | 2 +- > net/tap.c | 12 +++++++----- > net/vde.c | 5 +++-- > savevm.c | 2 +- > 35 files changed, 155 insertions(+), 90 deletions(-) Please split this into multiple patches: 1. net subsystem API change that touches all files (if necessary) 2. e1000 MORE support 3. virtio-net MORE support 4. netmap MORE support This makes it easier to review and bisect. Thanks, Stefan