From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35240)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Vq32H-0001dL-ID
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 10:46:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Vq329-0000TT-0o
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 10:46:17 -0500
Received: from nodalink.pck.nerim.net ([62.212.105.220]:46514
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Vq328-0000TM-NT
	for qemu-devel@nongnu.org; Mon, 09 Dec 2013 10:46:08 -0500
Date: Mon, 9 Dec 2013 16:46:03 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20131209154603.GD3364@irqsave.net>
References: <1386263703-19292-1-git-send-email-benoit@irqsave.net>
	<1386263703-19292-4-git-send-email-benoit@irqsave.net>
	<52A1F46A.9000307@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <52A1F46A.9000307@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V4 3/7] qmp: Add a command to list the
 named BlockDriverState nodes.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com

Le Friday 06 Dec 2013 =E0 08:59:38 (-0700), Eric Blake a =E9crit :
> On 12/05/2013 10:14 AM, Beno=EEt Canet wrote:
> > Signed-off-by: Benoit Canet <benoit@irqsave.net>
> > ---
> >  block.c               | 16 ++++++++++++++++
> >  blockdev.c            |  5 +++++
> >  include/block/block.h |  1 +
> >  qapi-schema.json      | 11 +++++++++++
> >  qmp-commands.hx       | 19 +++++++++++++++++++
> >  5 files changed, 52 insertions(+)
>=20
> >  ##
> > +# @query-named-block-nodes
> > +#
> > +# Get the named block driver list
> > +#
> > +# Returns: the list of named nodes names
>=20
> Sounds funny.  Maybe better with just:
>=20
> Returns: the list of names
>=20
> > +#
> > +# Since 2.0
> > +##
> > +{ 'command': 'query-named-block-nodes', 'returns': [ 'str' ] }
>=20
> Also, is list of names sufficient, or are we better off returning a lis=
t
> of structs with the details already included?  With list of names, the
> management app has to follow up with another QMP command per name if it
> wants to know details about each node, instead of getting it all in one
> command.

Would a list of BlockDeviceInfo be fine ?

Best regards

Beno=EEt

>=20
> > +SQMP
> > +@query-named-block-nodes
> > +------------------------
> > +
> > +Return a list of string containing the name of the named block drive=
r states
>=20
> Return a list of strings containing the name of each named block driver=
 node
>=20
> --=20
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20