From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq3Ek-00066W-Rb for qemu-devel@nongnu.org; Mon, 09 Dec 2013 10:59:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vq3Ef-0004uL-LP for qemu-devel@nongnu.org; Mon, 09 Dec 2013 10:59:10 -0500 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:35374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq3Ef-0004sB-CZ for qemu-devel@nongnu.org; Mon, 09 Dec 2013 10:59:05 -0500 Date: Mon, 9 Dec 2013 16:58:55 +0100 From: Aurelien Jarno Message-ID: <20131209155855.GC5013@ohm.rr44.fr> References: <1386424088-23196-1-git-send-email-sw@weilnetz.de> <1386424088-23196-5-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1386424088-23196-5-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH v2 4/5] target-mips: Use macro ARRAY_SIZE where possible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, qemu-devel On Sat, Dec 07, 2013 at 02:48:07PM +0100, Stefan Weil wrote: > This improves readability and simplifies the code. > > Cc: Aurelien Jarno > Signed-off-by: Stefan Weil > --- > target-mips/dsp_helper.c | 30 ++++++++++++------------------ > 1 file changed, 12 insertions(+), 18 deletions(-) > > diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c > index b088a25..a2f46d9 100644 > --- a/target-mips/dsp_helper.c > +++ b/target-mips/dsp_helper.c > @@ -1088,12 +1088,11 @@ static inline int32_t mipsdsp_cmpu_lt(uint32_t a, uint32_t b) > target_ulong helper_##name(target_ulong rt, CPUMIPSState *env) \ > { \ > DSP32Value dt; \ > - unsigned int i, n; \ > + unsigned int i; \ > \ > - n = sizeof(DSP32Value) / sizeof(dt.element[0]); \ > dt.sw[0] = rt; \ > \ > - for (i = 0; i < n; i++) { \ > + for (i = 0; i < ARRAY_SIZE(dt.element); i++) { \ > dt.element[i] = mipsdsp_##func(dt.element[i], env); \ > } \ > \ > @@ -1109,12 +1108,11 @@ MIPSDSP32_UNOP_ENV(absq_s_w, sat_abs32, sw) > target_ulong helper_##name(target_ulong rt, CPUMIPSState *env) \ > { \ > DSP64Value dt; \ > - unsigned int i, n; \ > + unsigned int i; \ > \ > - n = sizeof(DSP64Value) / sizeof(dt.element[0]); \ > dt.sl[0] = rt; \ > \ > - for (i = 0; i < n; i++) { \ > + for (i = 0; i < ARRAY_SIZE(dt.element); i++) { \ > dt.element[i] = mipsdsp_##func(dt.element[i], env); \ > } \ > \ > @@ -1130,13 +1128,12 @@ MIPSDSP64_UNOP_ENV(absq_s_pw, sat_abs32, sw) > target_ulong helper_##name(target_ulong rs, target_ulong rt) \ > { \ > DSP32Value ds, dt; \ > - unsigned int i, n; \ > + unsigned int i; \ > \ > - n = sizeof(DSP32Value) / sizeof(ds.element[0]); \ > ds.sw[0] = rs; \ > dt.sw[0] = rt; \ > \ > - for (i = 0; i < n; i++) { \ > + for (i = 0; i < ARRAY_SIZE(ds.element); i++) { \ > ds.element[i] = mipsdsp_##func(ds.element[i], dt.element[i]); \ > } \ > \ > @@ -1159,13 +1156,12 @@ target_ulong helper_##name(target_ulong rs, target_ulong rt, \ > CPUMIPSState *env) \ > { \ > DSP32Value ds, dt; \ > - unsigned int i, n; \ > + unsigned int i; \ > \ > - n = sizeof(DSP32Value) / sizeof(ds.element[0]); \ > ds.sw[0] = rs; \ > dt.sw[0] = rt; \ > \ > - for (i = 0 ; i < n ; i++) { \ > + for (i = 0 ; i < ARRAY_SIZE(ds.element); i++) { \ > ds.element[i] = mipsdsp_##func(ds.element[i], dt.element[i], env); \ > } \ > \ > @@ -1192,13 +1188,12 @@ MIPSDSP32_BINOP_ENV(subu_s_qb, satu8_sub, ub); > target_ulong helper_##name(target_ulong rs, target_ulong rt) \ > { \ > DSP64Value ds, dt; \ > - unsigned int i, n; \ > + unsigned int i; \ > \ > - n = sizeof(DSP64Value) / sizeof(ds.element[0]); \ > ds.sl[0] = rs; \ > dt.sl[0] = rt; \ > \ > - for (i = 0 ; i < n ; i++) { \ > + for (i = 0 ; i < ARRAY_SIZE(ds.element); i++) { \ > ds.element[i] = mipsdsp_##func(ds.element[i], dt.element[i]); \ > } \ > \ > @@ -1215,13 +1210,12 @@ target_ulong helper_##name(target_ulong rs, target_ulong rt, \ > CPUMIPSState *env) \ > { \ > DSP64Value ds, dt; \ > - unsigned int i, n; \ > + unsigned int i; \ > \ > - n = sizeof(DSP64Value) / sizeof(ds.element[0]); \ > ds.sl[0] = rs; \ > dt.sl[0] = rt; \ > \ > - for (i = 0 ; i < n ; i++) { \ > + for (i = 0 ; i < ARRAY_SIZE(ds.element); i++) { \ > ds.element[i] = mipsdsp_##func(ds.element[i], dt.element[i], env); \ > } \ > \ Thanks, applied. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net