* [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
@ 2013-12-11 0:49 Brad Smith
2013-12-15 4:27 ` Brad Smith
2014-01-02 7:55 ` Stefan Hajnoczi
0 siblings, 2 replies; 15+ messages in thread
From: Brad Smith @ 2013-12-11 0:49 UTC (permalink / raw)
To: qemu-devel
This resolves the build issue with building the ROMs on OpenBSD on x86 archs.
As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the
whole OS/packages and so forth. The ROMs need to have PIE disabled. This
is my initial attempt at trying to get somehting upstream so that QEMU
both builds out of the box and to resolve the build issue with the
buildbots that has been around for awhile. We have a patch in our ports
tree but it is just the flags hardcoded into the Makefile which obviously
is not appropriate for upstream.
>From the OpenBSD buildbots..
Building optionrom/multiboot.img
ld: multiboot.o: relocation R_X86_64_16 can not be used when making a shared object; recompile with -fPIC
Signed-off by: Brad Smith <brad@comstyle.com>
---
Change in v2:
* Fix '==' is not portable syntax.
Change in v3:
* Rename variables and use compile_prog to detect the presence of the compiler/linker
flags, as suggested by Stefan Weil.
diff --git a/configure b/configure
index 5d82283..89ae89d 100755
--- a/configure
+++ b/configure
@@ -1365,6 +1365,11 @@ EOF
pie="no"
fi
fi
+
+ if compile_prog "-fno-pie" "-nopie"; then
+ CFLAGS_NOPIE="-fno-pie"
+ LDFLAGS_NOPIE="-nopie"
+ fi
fi
##########################################
@@ -4320,6 +4325,7 @@ echo "LD=$ld" >> $config_host_mak
echo "WINDRES=$windres" >> $config_host_mak
echo "LIBTOOL=$libtool" >> $config_host_mak
echo "CFLAGS=$CFLAGS" >> $config_host_mak
+echo "CFLAGS_NOPIE=$CFLAGS_NOPIE" >> $config_host_mak
echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
echo "QEMU_INCLUDES=$QEMU_INCLUDES" >> $config_host_mak
if test "$sparse" = "yes" ; then
@@ -4333,6 +4339,7 @@ else
echo "AUTOCONF_HOST := " >> $config_host_mak
fi
echo "LDFLAGS=$LDFLAGS" >> $config_host_mak
+echo "LDFLAGS_NOPIE=$LDFLAGS_NOPIE" >> $config_host_mak
echo "LIBTOOLFLAGS=$LIBTOOLFLAGS" >> $config_host_mak
echo "LIBS+=$LIBS" >> $config_host_mak
echo "LIBS_TOOLS+=$libs_tools" >> $config_host_mak
diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile
index 57d8bd0..ce4852a 100644
--- a/pc-bios/optionrom/Makefile
+++ b/pc-bios/optionrom/Makefile
@@ -12,6 +12,7 @@ $(call set-vpath, $(SRC_PATH)/pc-bios/optionrom)
CFLAGS := -Wall -Wstrict-prototypes -Werror -fomit-frame-pointer -fno-builtin
CFLAGS += -I$(SRC_PATH)
CFLAGS += $(call cc-option, $(CFLAGS), -fno-stack-protector)
+CFLAGS += $(CFLAGS_NOPIE)
QEMU_CFLAGS = $(CFLAGS)
build-all: multiboot.bin linuxboot.bin kvmvapic.bin
@@ -20,7 +21,7 @@ build-all: multiboot.bin linuxboot.bin kvmvapic.bin
.SECONDARY:
%.img: %.o
- $(call quiet-command,$(LD) -Ttext 0 -e _start -s -o $@ $<," Building $(TARGET_DIR)$@")
+ $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e _start -s -o $@ $<," Building $(TARGET_DIR)$@")
%.raw: %.img
$(call quiet-command,$(OBJCOPY) -O binary -j .text $< $@," Building $(TARGET_DIR)$@")
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2013-12-11 0:49 [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs Brad Smith
@ 2013-12-15 4:27 ` Brad Smith
2013-12-20 11:19 ` Brad Smith
2014-01-02 7:55 ` Stefan Hajnoczi
1 sibling, 1 reply; 15+ messages in thread
From: Brad Smith @ 2013-12-15 4:27 UTC (permalink / raw)
To: qemu-devel
On 10/12/13 7:49 PM, Brad Smith wrote:
> This resolves the build issue with building the ROMs on OpenBSD on x86 archs.
> As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the
> whole OS/packages and so forth. The ROMs need to have PIE disabled. This
> is my initial attempt at trying to get somehting upstream so that QEMU
> both builds out of the box and to resolve the build issue with the
> buildbots that has been around for awhile. We have a patch in our ports
> tree but it is just the flags hardcoded into the Makefile which obviously
> is not appropriate for upstream.
>
> From the OpenBSD buildbots..
> Building optionrom/multiboot.img
> ld: multiboot.o: relocation R_X86_64_16 can not be used when making a shared object; recompile with -fPIC
>
> Signed-off by: Brad Smith <brad@comstyle.com>
ping.
> ---
>
> Change in v2:
> * Fix '==' is not portable syntax.
>
> Change in v3:
> * Rename variables and use compile_prog to detect the presence of the compiler/linker
> flags, as suggested by Stefan Weil.
>
> diff --git a/configure b/configure
> index 5d82283..89ae89d 100755
> --- a/configure
> +++ b/configure
> @@ -1365,6 +1365,11 @@ EOF
> pie="no"
> fi
> fi
> +
> + if compile_prog "-fno-pie" "-nopie"; then
> + CFLAGS_NOPIE="-fno-pie"
> + LDFLAGS_NOPIE="-nopie"
> + fi
> fi
>
> ##########################################
> @@ -4320,6 +4325,7 @@ echo "LD=$ld" >> $config_host_mak
> echo "WINDRES=$windres" >> $config_host_mak
> echo "LIBTOOL=$libtool" >> $config_host_mak
> echo "CFLAGS=$CFLAGS" >> $config_host_mak
> +echo "CFLAGS_NOPIE=$CFLAGS_NOPIE" >> $config_host_mak
> echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
> echo "QEMU_INCLUDES=$QEMU_INCLUDES" >> $config_host_mak
> if test "$sparse" = "yes" ; then
> @@ -4333,6 +4339,7 @@ else
> echo "AUTOCONF_HOST := " >> $config_host_mak
> fi
> echo "LDFLAGS=$LDFLAGS" >> $config_host_mak
> +echo "LDFLAGS_NOPIE=$LDFLAGS_NOPIE" >> $config_host_mak
> echo "LIBTOOLFLAGS=$LIBTOOLFLAGS" >> $config_host_mak
> echo "LIBS+=$LIBS" >> $config_host_mak
> echo "LIBS_TOOLS+=$libs_tools" >> $config_host_mak
> diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile
> index 57d8bd0..ce4852a 100644
> --- a/pc-bios/optionrom/Makefile
> +++ b/pc-bios/optionrom/Makefile
> @@ -12,6 +12,7 @@ $(call set-vpath, $(SRC_PATH)/pc-bios/optionrom)
> CFLAGS := -Wall -Wstrict-prototypes -Werror -fomit-frame-pointer -fno-builtin
> CFLAGS += -I$(SRC_PATH)
> CFLAGS += $(call cc-option, $(CFLAGS), -fno-stack-protector)
> +CFLAGS += $(CFLAGS_NOPIE)
> QEMU_CFLAGS = $(CFLAGS)
>
> build-all: multiboot.bin linuxboot.bin kvmvapic.bin
> @@ -20,7 +21,7 @@ build-all: multiboot.bin linuxboot.bin kvmvapic.bin
> .SECONDARY:
>
> %.img: %.o
> - $(call quiet-command,$(LD) -Ttext 0 -e _start -s -o $@ $<," Building $(TARGET_DIR)$@")
> + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e _start -s -o $@ $<," Building $(TARGET_DIR)$@")
>
> %.raw: %.img
> $(call quiet-command,$(OBJCOPY) -O binary -j .text $< $@," Building $(TARGET_DIR)$@")
>
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2013-12-15 4:27 ` Brad Smith
@ 2013-12-20 11:19 ` Brad Smith
2014-01-14 19:08 ` Brad Smith
0 siblings, 1 reply; 15+ messages in thread
From: Brad Smith @ 2013-12-20 11:19 UTC (permalink / raw)
To: qemu-devel
On 14/12/13 11:27 PM, Brad Smith wrote:
> On 10/12/13 7:49 PM, Brad Smith wrote:
>> This resolves the build issue with building the ROMs on OpenBSD on x86
>> archs.
>> As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus
>> the
>> whole OS/packages and so forth. The ROMs need to have PIE disabled. This
>> is my initial attempt at trying to get somehting upstream so that QEMU
>> both builds out of the box and to resolve the build issue with the
>> buildbots that has been around for awhile. We have a patch in our ports
>> tree but it is just the flags hardcoded into the Makefile which obviously
>> is not appropriate for upstream.
>>
>> From the OpenBSD buildbots..
>> Building optionrom/multiboot.img
>> ld: multiboot.o: relocation R_X86_64_16 can not be used when making a
>> shared object; recompile with -fPIC
>>
>> Signed-off by: Brad Smith <brad@comstyle.com>
>
> ping.
ping ping.
>> ---
>>
>> Change in v2:
>> * Fix '==' is not portable syntax.
>>
>> Change in v3:
>> * Rename variables and use compile_prog to detect the presence of
>> the compiler/linker
>> flags, as suggested by Stefan Weil.
>>
>> diff --git a/configure b/configure
>> index 5d82283..89ae89d 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1365,6 +1365,11 @@ EOF
>> pie="no"
>> fi
>> fi
>> +
>> + if compile_prog "-fno-pie" "-nopie"; then
>> + CFLAGS_NOPIE="-fno-pie"
>> + LDFLAGS_NOPIE="-nopie"
>> + fi
>> fi
>>
>> ##########################################
>> @@ -4320,6 +4325,7 @@ echo "LD=$ld" >> $config_host_mak
>> echo "WINDRES=$windres" >> $config_host_mak
>> echo "LIBTOOL=$libtool" >> $config_host_mak
>> echo "CFLAGS=$CFLAGS" >> $config_host_mak
>> +echo "CFLAGS_NOPIE=$CFLAGS_NOPIE" >> $config_host_mak
>> echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
>> echo "QEMU_INCLUDES=$QEMU_INCLUDES" >> $config_host_mak
>> if test "$sparse" = "yes" ; then
>> @@ -4333,6 +4339,7 @@ else
>> echo "AUTOCONF_HOST := " >>
>> $config_host_mak
>> fi
>> echo "LDFLAGS=$LDFLAGS" >> $config_host_mak
>> +echo "LDFLAGS_NOPIE=$LDFLAGS_NOPIE" >> $config_host_mak
>> echo "LIBTOOLFLAGS=$LIBTOOLFLAGS" >> $config_host_mak
>> echo "LIBS+=$LIBS" >> $config_host_mak
>> echo "LIBS_TOOLS+=$libs_tools" >> $config_host_mak
>> diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile
>> index 57d8bd0..ce4852a 100644
>> --- a/pc-bios/optionrom/Makefile
>> +++ b/pc-bios/optionrom/Makefile
>> @@ -12,6 +12,7 @@ $(call set-vpath, $(SRC_PATH)/pc-bios/optionrom)
>> CFLAGS := -Wall -Wstrict-prototypes -Werror -fomit-frame-pointer
>> -fno-builtin
>> CFLAGS += -I$(SRC_PATH)
>> CFLAGS += $(call cc-option, $(CFLAGS), -fno-stack-protector)
>> +CFLAGS += $(CFLAGS_NOPIE)
>> QEMU_CFLAGS = $(CFLAGS)
>>
>> build-all: multiboot.bin linuxboot.bin kvmvapic.bin
>> @@ -20,7 +21,7 @@ build-all: multiboot.bin linuxboot.bin kvmvapic.bin
>> .SECONDARY:
>>
>> %.img: %.o
>> - $(call quiet-command,$(LD) -Ttext 0 -e _start -s -o $@ $<,"
>> Building $(TARGET_DIR)$@")
>> + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e _start -s
>> -o $@ $<," Building $(TARGET_DIR)$@")
>>
>> %.raw: %.img
>> $(call quiet-command,$(OBJCOPY) -O binary -j .text $< $@,"
>> Building $(TARGET_DIR)$@")
>>
>
>
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2013-12-20 11:19 ` Brad Smith
@ 2014-01-14 19:08 ` Brad Smith
0 siblings, 0 replies; 15+ messages in thread
From: Brad Smith @ 2014-01-14 19:08 UTC (permalink / raw)
To: qemu-devel
On 12/20/13 06:19, Brad Smith wrote:
> On 14/12/13 11:27 PM, Brad Smith wrote:
>> On 10/12/13 7:49 PM, Brad Smith wrote:
>>> This resolves the build issue with building the ROMs on OpenBSD on x86
>>> archs.
>>> As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus
>>> the
>>> whole OS/packages and so forth. The ROMs need to have PIE disabled.
>>> This
>>> is my initial attempt at trying to get somehting upstream so that QEMU
>>> both builds out of the box and to resolve the build issue with the
>>> buildbots that has been around for awhile. We have a patch in our ports
>>> tree but it is just the flags hardcoded into the Makefile which
>>> obviously
>>> is not appropriate for upstream.
>>>
>>> From the OpenBSD buildbots..
>>> Building optionrom/multiboot.img
>>> ld: multiboot.o: relocation R_X86_64_16 can not be used when making a
>>> shared object; recompile with -fPIC
>>>
>>> Signed-off by: Brad Smith <brad@comstyle.com>
>>
>> ping.
>
> ping ping.
ping ping ping.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2013-12-11 0:49 [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs Brad Smith
2013-12-15 4:27 ` Brad Smith
@ 2014-01-02 7:55 ` Stefan Hajnoczi
2014-01-26 1:37 ` Brad Smith
1 sibling, 1 reply; 15+ messages in thread
From: Stefan Hajnoczi @ 2014-01-02 7:55 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Brad Smith
On Tue, Dec 10, 2013 at 07:49:08PM -0500, Brad Smith wrote:
> This resolves the build issue with building the ROMs on OpenBSD on x86 archs.
> As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the
> whole OS/packages and so forth. The ROMs need to have PIE disabled. This
> is my initial attempt at trying to get somehting upstream so that QEMU
> both builds out of the box and to resolve the build issue with the
> buildbots that has been around for awhile. We have a patch in our ports
> tree but it is just the flags hardcoded into the Makefile which obviously
> is not appropriate for upstream.
>
> From the OpenBSD buildbots..
> Building optionrom/multiboot.img
> ld: multiboot.o: relocation R_X86_64_16 can not be used when making a shared object; recompile with -fPIC
>
> Signed-off by: Brad Smith <brad@comstyle.com>
> ---
>
> Change in v2:
> * Fix '==' is not portable syntax.
>
> Change in v3:
> * Rename variables and use compile_prog to detect the presence of the compiler/linker
> flags, as suggested by Stefan Weil.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-01-02 7:55 ` Stefan Hajnoczi
@ 2014-01-26 1:37 ` Brad Smith
2014-01-26 18:06 ` Paolo Bonzini
0 siblings, 1 reply; 15+ messages in thread
From: Brad Smith @ 2014-01-26 1:37 UTC (permalink / raw)
To: Stefan Hajnoczi, Anthony Liguori; +Cc: qemu-devel
On 02/01/14 2:55 AM, Stefan Hajnoczi wrote:
> On Tue, Dec 10, 2013 at 07:49:08PM -0500, Brad Smith wrote:
>> This resolves the build issue with building the ROMs on OpenBSD on x86 archs.
>> As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the
>> whole OS/packages and so forth. The ROMs need to have PIE disabled. This
>> is my initial attempt at trying to get somehting upstream so that QEMU
>> both builds out of the box and to resolve the build issue with the
>> buildbots that has been around for awhile. We have a patch in our ports
>> tree but it is just the flags hardcoded into the Makefile which obviously
>> is not appropriate for upstream.
>>
>> From the OpenBSD buildbots..
>> Building optionrom/multiboot.img
>> ld: multiboot.o: relocation R_X86_64_16 can not be used when making a shared object; recompile with -fPIC
>>
>> Signed-off by: Brad Smith <brad@comstyle.com>
>> ---
>>
>> Change in v2:
>> * Fix '==' is not portable syntax.
>>
>> Change in v3:
>> * Rename variables and use compile_prog to detect the presence of the compiler/linker
>> flags, as suggested by Stefan Weil.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Is there some sort of process I am missing to have build fixes
commited so that QEMU actually builds?
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-01-26 1:37 ` Brad Smith
@ 2014-01-26 18:06 ` Paolo Bonzini
2014-01-26 21:40 ` Brad Smith
2014-02-16 22:00 ` Brad Smith
0 siblings, 2 replies; 15+ messages in thread
From: Paolo Bonzini @ 2014-01-26 18:06 UTC (permalink / raw)
To: Brad Smith, Stefan Hajnoczi, Anthony Liguori; +Cc: qemu-devel
Il 26/01/2014 02:37, Brad Smith ha scritto:
>>>
>>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Is there some sort of process I am missing to have build fixes
> commited so that QEMU actually builds?
Right now we have problems getting patches committed at all.
This patch and the other NetBSD patch is not lost.
Paolo
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-01-26 18:06 ` Paolo Bonzini
@ 2014-01-26 21:40 ` Brad Smith
2014-01-26 22:12 ` Anthony Liguori
2014-02-16 22:00 ` Brad Smith
1 sibling, 1 reply; 15+ messages in thread
From: Brad Smith @ 2014-01-26 21:40 UTC (permalink / raw)
To: Paolo Bonzini, Stefan Hajnoczi, Anthony Liguori; +Cc: qemu-devel
On 26/01/14 1:06 PM, Paolo Bonzini wrote:
> Il 26/01/2014 02:37, Brad Smith ha scritto:
>>>>
>>>
>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>
>> Is there some sort of process I am missing to have build fixes
>> commited so that QEMU actually builds?
>
> Right now we have problems getting patches committed at all.
>
> This patch and the other NetBSD patch is not lost.
I know it is not literally lost.
I don't follow the list that closely.. what was the reason
for there being two incidents over the last 2 months of there
being no commits for over a week (at least from the perspective
of git.qemu.org)?
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-01-26 21:40 ` Brad Smith
@ 2014-01-26 22:12 ` Anthony Liguori
2014-01-26 23:04 ` Brad Smith
0 siblings, 1 reply; 15+ messages in thread
From: Anthony Liguori @ 2014-01-26 22:12 UTC (permalink / raw)
To: Brad Smith
Cc: Peter Maydell, Paolo Bonzini, qemu-devel, Anthony Liguori,
Stefan Hajnoczi
On Sun, Jan 26, 2014 at 1:40 PM, Brad Smith <brad@comstyle.com> wrote:
> On 26/01/14 1:06 PM, Paolo Bonzini wrote:
>>
>> Il 26/01/2014 02:37, Brad Smith ha scritto:
>>>>>
>>>>>
>>>>
>>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>>
>>>
>>> Is there some sort of process I am missing to have build fixes
>>> commited so that QEMU actually builds?
>>
>>
>> Right now we have problems getting patches committed at all.
>>
>> This patch and the other NetBSD patch is not lost.
>
>
> I know it is not literally lost.
>
> I don't follow the list that closely.. what was the reason
> for there being two incidents over the last 2 months of there
> being no commits for over a week (at least from the perspective
> of git.qemu.org)?
Historically, having multiple committers has avoided this problem
because when one person gets bogged down, there's someone else to step
up.
Right now, it seems all current committers are in a bogged down state.
I've added another committer, Peter Maydell, to try to break the log
jam. I'll try to devote more time to applying patches but hopefully
with Peter's help too, we can get things moving at the appropriate
speed again.
Regards,
Anthony Liguori
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-01-26 22:12 ` Anthony Liguori
@ 2014-01-26 23:04 ` Brad Smith
0 siblings, 0 replies; 15+ messages in thread
From: Brad Smith @ 2014-01-26 23:04 UTC (permalink / raw)
To: Anthony Liguori
Cc: Peter Maydell, Paolo Bonzini, qemu-devel, Anthony Liguori,
Stefan Hajnoczi
On 26/01/14 5:12 PM, Anthony Liguori wrote:
> On Sun, Jan 26, 2014 at 1:40 PM, Brad Smith <brad@comstyle.com> wrote:
>> On 26/01/14 1:06 PM, Paolo Bonzini wrote:
>>>
>>> Il 26/01/2014 02:37, Brad Smith ha scritto:
>>>>>>
>>>>>>
>>>>>
>>>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>>>
>>>>
>>>> Is there some sort of process I am missing to have build fixes
>>>> commited so that QEMU actually builds?
>>>
>>>
>>> Right now we have problems getting patches committed at all.
>>>
>>> This patch and the other NetBSD patch is not lost.
>>
>>
>> I know it is not literally lost.
>>
>> I don't follow the list that closely.. what was the reason
>> for there being two incidents over the last 2 months of there
>> being no commits for over a week (at least from the perspective
>> of git.qemu.org)?
>
> Historically, having multiple committers has avoided this problem
> because when one person gets bogged down, there's someone else to step
> up.
>
> Right now, it seems all current committers are in a bogged down state.
>
> I've added another committer, Peter Maydell, to try to break the log
> jam. I'll try to devote more time to applying patches but hopefully
> with Peter's help too, we can get things moving at the appropriate
> speed again.
Ok, I see. Thank you for the response.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-01-26 18:06 ` Paolo Bonzini
2014-01-26 21:40 ` Brad Smith
@ 2014-02-16 22:00 ` Brad Smith
2014-02-17 16:20 ` Peter Maydell
1 sibling, 1 reply; 15+ messages in thread
From: Brad Smith @ 2014-02-16 22:00 UTC (permalink / raw)
To: Paolo Bonzini, Stefan Hajnoczi, Anthony Liguori; +Cc: qemu-devel
On 26/01/14 1:06 PM, Paolo Bonzini wrote:
> Il 26/01/2014 02:37, Brad Smith ha scritto:
>>>>
>>>
>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>
>> Is there some sort of process I am missing to have build fixes
>> commited so that QEMU actually builds?
>
> Right now we have problems getting patches committed at all.
>
> This patch and the other NetBSD patch is not lost.
>
> Paolo
ping.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-02-16 22:00 ` Brad Smith
@ 2014-02-17 16:20 ` Peter Maydell
2014-02-18 0:36 ` Brad Smith
0 siblings, 1 reply; 15+ messages in thread
From: Peter Maydell @ 2014-02-17 16:20 UTC (permalink / raw)
To: Brad Smith
Cc: Paolo Bonzini, QEMU Developers, Anthony Liguori, Stefan Hajnoczi
On 16 February 2014 22:00, Brad Smith <brad@comstyle.com> wrote:
> On 26/01/14 1:06 PM, Paolo Bonzini wrote:
>>
>> Il 26/01/2014 02:37, Brad Smith ha scritto:
>>>>>
>>>>>
>>>>
>>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>>
>>>
>>> Is there some sort of process I am missing to have build fixes
>>> commited so that QEMU actually builds?
>>
>>
>> Right now we have problems getting patches committed at all.
>>
>> This patch and the other NetBSD patch is not lost.
>>
>> Paolo
>
>
> ping.
Applied, thanks. Apologies for the delays.
-- PMM
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-02-17 16:20 ` Peter Maydell
@ 2014-02-18 0:36 ` Brad Smith
2014-02-18 9:45 ` Peter Maydell
0 siblings, 1 reply; 15+ messages in thread
From: Brad Smith @ 2014-02-18 0:36 UTC (permalink / raw)
To: Peter Maydell
Cc: Paolo Bonzini, QEMU Developers, Anthony Liguori, Stefan Hajnoczi
On 17/02/14 11:20 AM, Peter Maydell wrote:
> On 16 February 2014 22:00, Brad Smith <brad@comstyle.com> wrote:
>> On 26/01/14 1:06 PM, Paolo Bonzini wrote:
>>>
>>> Il 26/01/2014 02:37, Brad Smith ha scritto:
>>>>>>
>>>>>>
>>>>>
>>>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>>>
>>>>
>>>> Is there some sort of process I am missing to have build fixes
>>>> commited so that QEMU actually builds?
>>>
>>>
>>> Right now we have problems getting patches committed at all.
>>>
>>> This patch and the other NetBSD patch is not lost.
>>>
>>> Paolo
>>
>>
>> ping.
>
> Applied, thanks. Apologies for the delays.
Thank you very much.
Just one issue... just curious why my last name is missing
from the commit?
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-02-18 0:36 ` Brad Smith
@ 2014-02-18 9:45 ` Peter Maydell
2014-02-18 18:02 ` Brad Smith
0 siblings, 1 reply; 15+ messages in thread
From: Peter Maydell @ 2014-02-18 9:45 UTC (permalink / raw)
To: Brad Smith
Cc: Paolo Bonzini, QEMU Developers, Anthony Liguori, Stefan Hajnoczi
On 18 February 2014 00:36, Brad Smith <brad@comstyle.com> wrote:
> Just one issue... just curious why my last name is missing
> from the commit?
Ah, we've run into a bug in patchwork. I downloaded your patch:
http://patchwork.ozlabs.org/patch/299656/
but patchwork reconstructs patch mboxes from its database
rather than just returning the original email, and it has a bug
where it will always remember the name used by the very
first email it ever saw from you. I guess it has a patch in
the system way back from you with a misconfigured fullname.
Sorry about that. I know they've discussed this issue on the
patchwork mailing list but they obviously haven't implemented
a fix yet.
thanks
-- PMM
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs
2014-02-18 9:45 ` Peter Maydell
@ 2014-02-18 18:02 ` Brad Smith
0 siblings, 0 replies; 15+ messages in thread
From: Brad Smith @ 2014-02-18 18:02 UTC (permalink / raw)
To: Peter Maydell
Cc: Paolo Bonzini, QEMU Developers, Anthony Liguori, Stefan Hajnoczi
On 18/02/14 4:45 AM, Peter Maydell wrote:
> On 18 February 2014 00:36, Brad Smith <brad@comstyle.com> wrote:
>> Just one issue... just curious why my last name is missing
>> from the commit?
>
> Ah, we've run into a bug in patchwork. I downloaded your patch:
> http://patchwork.ozlabs.org/patch/299656/
>
> but patchwork reconstructs patch mboxes from its database
> rather than just returning the original email, and it has a bug
> where it will always remember the name used by the very
> first email it ever saw from you. I guess it has a patch in
> the system way back from you with a misconfigured fullname.
> Sorry about that. I know they've discussed this issue on the
> patchwork mailing list but they obviously haven't implemented
> a fix yet.
Well, it was intentionally left out back then but that was quite
awhile ago. I have changed my e-mail setup since then to include
the last name. Anyway, thanks for looking into this.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2014-02-18 18:02 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-11 0:49 [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs Brad Smith
2013-12-15 4:27 ` Brad Smith
2013-12-20 11:19 ` Brad Smith
2014-01-14 19:08 ` Brad Smith
2014-01-02 7:55 ` Stefan Hajnoczi
2014-01-26 1:37 ` Brad Smith
2014-01-26 18:06 ` Paolo Bonzini
2014-01-26 21:40 ` Brad Smith
2014-01-26 22:12 ` Anthony Liguori
2014-01-26 23:04 ` Brad Smith
2014-02-16 22:00 ` Brad Smith
2014-02-17 16:20 ` Peter Maydell
2014-02-18 0:36 ` Brad Smith
2014-02-18 9:45 ` Peter Maydell
2014-02-18 18:02 ` Brad Smith
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).