From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55421)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Vqjip-000074-9q
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 08:21:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Vqjij-0000lx-Aa
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 08:21:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27439)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Vqjij-0000lr-2m
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 08:20:57 -0500
Date: Wed, 11 Dec 2013 08:20:49 -0500
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20131211082049.648bf4fc@redhat.com>
In-Reply-To: <52A7E17C.8040504@redhat.com>
References: <1386263703-19292-1-git-send-email-benoit@irqsave.net>
	<1386263703-19292-5-git-send-email-benoit@irqsave.net>
	<20131206092703.5d60345a@redhat.com> <52A1EC31.7000709@redhat.com>
	<20131206115215.0427a956@redhat.com>
	<20131209162309.GJ3549@dhcp-200-207.str.redhat.com>
	<20131209114109.1c4a8d5f@redhat.com>
	<20131210095750.GC3656@dhcp-200-207.str.redhat.com>
	<20131210090620.4bc73895@redhat.com>
	<20131210142507.GE3656@dhcp-200-207.str.redhat.com>
	<20131210101613.7a38dadc@redhat.com> <52A7E17C.8040504@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on
 names block driver states.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, =?UTF-8?B?QmVub8OudA==?= Canet <benoit@irqsave.net>, jcody@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, 11 Dec 2013 11:52:28 +0800
Fam Zheng <famz@redhat.com> wrote:

> On 2013=E5=B9=B412=E6=9C=8810=E6=97=A5 23:16, Luiz Capitulino wrote:
> > On Tue, 10 Dec 2013 15:25:07 +0100
> > Kevin Wolf <kwolf@redhat.com> wrote:
> >
> >> My objection to your approach is strong because Beno=C3=AEt already se=
nt an
> >> alternative which I believe is less worse because with it, arguments
> >> actually mean what their names tell instead of having additional bools
> >> for "oh, and I said A, but I didn't mean it, I really want B".
> >
> > Current proposal:
> >
> > { 'command': 'block_passwd', 'data': {'*device': 'str',
> >                                        '*node-name': 'str', 'password':=
 'str'} }
> >
>=20
> I vote for this.

Ok. As it's clear that I've failed to demonstrate how I think we're
going to move all those commands into the wrong direction, I think it's
time to withdrawn my suggestion.