From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52662)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VqfKj-00007V-OF
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 03:39:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VqfKY-0001j3-LF
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 03:39:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30853)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VqfKY-0001it-D7
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 03:39:42 -0500
Date: Wed, 11 Dec 2013 09:39:36 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20131211083936.GC31406@stefanha-thinkpad.muc.redhat.com>
References: <1386594692-21278-1-git-send-email-stefanha@redhat.com>
	<1386594692-21278-2-git-send-email-stefanha@redhat.com>
	<52A7540C.8000006@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52A7540C.8000006@redhat.com>
Subject: Re: [Qemu-devel] [PULL 1/4] net: Adding netmap network backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Vincenzo Maffione <v.maffione@gmail.com>, Anthony Liguori <aliguori@amazon.com>

On Tue, Dec 10, 2013 at 10:49:00AM -0700, Eric Blake wrote:
> On 12/09/2013 06:11 AM, Stefan Hajnoczi wrote:
> > +++ b/qapi-schema.json
> > @@ -3009,6 +3009,27 @@
> >      'hubid':     'int32' } }
> >  
> >  ##
> > +# @NetdevNetmapOptions
> > +#
> > +# Connect a client to a netmap-enabled NIC or to a VALE switch port
> > +#
> > +# @ifname: Either the name of an existing network interface supported by
> > +#          netmap, or the name of a VALE port (created on the fly).
> > +#          A VALE port name is in the form 'valeXXX:YYY', where XXX and
> > +#          YYY are non-negative integers. XXX identifies a switch and
> > +#          YYY identifies a port of the switch. VALE ports having the
> > +#          same XXX are therefore connected to the same switch.
> > +#
> > +# @devname: #optional path of the netmap device (default: '/dev/netmap').
> > +#
> > +# Since 1.8
> 
> s/1.8/2.0/

Thank you for spotting this.  Sending a separate patch to fix this since
the pull request has been merged.

Stefan