From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqj9t-0004bf-87 for qemu-devel@nongnu.org; Wed, 11 Dec 2013 07:45:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vqj9n-0006xa-8v for qemu-devel@nongnu.org; Wed, 11 Dec 2013 07:44:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqj9n-0006xN-19 for qemu-devel@nongnu.org; Wed, 11 Dec 2013 07:44:51 -0500 Date: Wed, 11 Dec 2013 13:44:41 +0100 From: Igor Mammedov Message-ID: <20131211134441.6a495c30@thinkpad> In-Reply-To: <1386764361-15260-11-git-send-email-pbonzini@redhat.com> References: <1386764361-15260-1-git-send-email-pbonzini@redhat.com> <1386764361-15260-11-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 10/14] qom: catch errors in object_property_add_child List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: stefanha@redhat.com, qemu-devel@nongnu.org, gaowanlong@cn.fujitsu.com On Wed, 11 Dec 2013 13:19:17 +0100 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qom/object.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index fc19cf6..68fe07a 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -988,17 +988,22 @@ static void object_finalize_child_property(Object *obj, const char *name, > void object_property_add_child(Object *obj, const char *name, > Object *child, Error **errp) > { > + Error *local_err = NULL; > gchar *type; > > type = g_strdup_printf("child<%s>", object_get_typename(OBJECT(child))); > > object_property_add(obj, name, type, object_get_child_property, > - NULL, object_finalize_child_property, child, errp); > - > + NULL, object_finalize_child_property, child, &local_err); > + if (error_is_set(&local_err)) { > + error_propagate(errp, local_err); > + goto out; > + } > object_ref(child); > g_assert(child->parent == NULL); > child->parent = obj; > > +out: > g_free(type); > } > > -- > 1.8.4.2 > > > Reviewed-By: Igor Mammedov -- Regards, Igor