From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: rusty@rustcorp.com.au, qemu-ppc@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] [PATCH V2] target-ppc: ppc64 target's virtio can be either endian.
Date: Wed, 11 Dec 2013 16:59:33 +0100 [thread overview]
Message-ID: <20131211155716.8373.27979.stgit@bahia.local> (raw)
In-Reply-To: <39557095-94C5-4E6E-8DE5-62C4A6C79F58@suse.de>
We base it on the OS endian, as reflected by the endianness of the
interrupt vectors (handled through the ILE bit in the LPCR register).
This patch does two things:
- make LPCR a KVM register
- implement virtio_get_byteswap() over LPCR
Using first_cpu to fetch the registers from KVM may look arbitrary
and awkward, but it is okay because KVM sets/unsets the ILE bit on
all CPUs.
Changes in v2:
- call cpu_synchronize_state() instead of kvm_arch_get_registers().
Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
---
Alex,
If you are interested, I can resend the whole virtio+endian serie or
setup a git tree for you to pull from.
--
Greg
target-ppc/kvm.c | 4 ++++
target-ppc/misc_helper.c | 12 ++++++++++++
2 files changed, 16 insertions(+)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 10d0cd9..b450a22 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -869,6 +869,8 @@ int kvm_arch_put_registers(CPUState *cs, int level)
DPRINTF("Warning: Unable to set VPA information to KVM\n");
}
}
+
+ kvm_put_one_spr(cs, KVM_REG_PPC_LPCR, SPR_LPCR);
#endif /* TARGET_PPC64 */
}
@@ -1091,6 +1093,8 @@ int kvm_arch_get_registers(CPUState *cs)
DPRINTF("Warning: Unable to get VPA information from KVM\n");
}
}
+
+ kvm_get_one_spr(cs, KVM_REG_PPC_LPCR, SPR_LPCR);
#endif
}
diff --git a/target-ppc/misc_helper.c b/target-ppc/misc_helper.c
index 616aab6..e8fc8a3 100644
--- a/target-ppc/misc_helper.c
+++ b/target-ppc/misc_helper.c
@@ -20,6 +20,8 @@
#include "helper.h"
#include "helper_regs.h"
+#include "hw/virtio/virtio.h"
+#include "sysemu/kvm.h"
/*****************************************************************************/
/* SPR accesses */
@@ -116,3 +118,13 @@ void ppc_store_msr(CPUPPCState *env, target_ulong value)
{
hreg_store_msr(env, value, 0);
}
+
+bool virtio_get_byteswap(void)
+{
+ PowerPCCPU *cp = POWERPC_CPU(first_cpu);
+ CPUPPCState *env = &cp->env;
+
+ cpu_synchronize_state(first_cpu);
+
+ return env->spr[SPR_LPCR] & LPCR_ILE;
+}
next prev parent reply other threads:[~2013-12-11 15:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 15:35 [Qemu-devel] [PATCH] target-ppc: ppc64 target's virtio can be either endian Greg Kurz
2013-12-09 15:33 ` Alexander Graf
2013-12-09 17:11 ` Greg Kurz
2013-12-09 17:18 ` Alexander Graf
2013-12-10 17:37 ` Greg Kurz
2013-12-10 17:48 ` Alexander Graf
2013-12-10 19:44 ` Greg Kurz
2013-12-10 22:25 ` Alexander Graf
2013-12-11 15:59 ` Greg Kurz [this message]
2013-12-11 16:11 ` [Qemu-devel] [PATCH V2] " Alexander Graf
2013-12-11 17:18 ` Greg Kurz
2014-01-17 13:52 ` [Qemu-devel] [PATCH] target-ppc: ppc64 target's virtio can be either endian. (v3) Greg Kurz
2014-01-20 14:36 ` Alexander Graf
2013-12-09 19:44 ` [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: ppc64 target's virtio can be either endian Benjamin Herrenschmidt
2013-12-10 1:18 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211155716.8373.27979.stgit@bahia.local \
--to=gkurz@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).