From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49796)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VrSv3-0007xK-Mb
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 08:36:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VrSv2-0006D3-96
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 08:36:41 -0500
Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:59211)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VrSv2-0006Ci-2s
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 08:36:40 -0500
Date: Fri, 13 Dec 2013 14:36:37 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20131213133637.GR4601@hall.aurel32.net>
References: <1386893227-18662-1-git-send-email-aurelien@aurel32.net>
	<877gb9gkj6.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <877gb9gkj6.fsf@linaro.org>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-sh4: Use new qemu_ld/st opcodes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex =?iso-8859-15?Q?Benn=E9e?= <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>

On Fri, Dec 13, 2013 at 09:36:13AM +0000, Alex Bennée wrote:
> 
> aurelien@aurel32.net writes:
> 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> >  target-sh4/translate.c |  167 ++++++++++++++++++++++++++----------------------
> >  1 file changed, 90 insertions(+), 77 deletions(-)
> >
> > diff --git a/target-sh4/translate.c b/target-sh4/translate.c
> > index 2272eb0..87f532a 100644
> > --- a/target-sh4/translate.c
> > +++ b/target-sh4/translate.c
> > @@ -464,7 +464,7 @@ static void _decode_opc(DisasContext * ctx)
> >  	{
> >  	    TCGv addr = tcg_temp_new();
> >  	    tcg_gen_addi_i32(addr, REG(B11_8), B3_0 * 4);
> > -	    tcg_gen_qemu_st32(REG(B7_4), addr, ctx->memidx);
> > +            tcg_gen_qemu_st_i32(REG(B7_4), addr, ctx->memidx, MO_TEUL);
> >  	    tcg_temp_free(addr);
> <snip>
> 
> There seems to be a fix of tabs and spaces in that patch.
> 

Indeed, this file is partly tabs indented for historical reasons, so
they are changed to space in the patch, to conform to the QEMU coding
style. AFAIK there is a consensus that things should be done that way.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net