From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZTo-0004b1-6H for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrZTi-000428-8X for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:37:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZTi-00041w-0Q for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:36:54 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDKar0x011184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 15:36:53 -0500 Date: Fri, 13 Dec 2013 21:36:50 +0100 From: Kevin Wolf Message-ID: <20131213203650.GC3916@dhcp-200-207.str.redhat.com> References: <1386954633-28905-1-git-send-email-mreitz@redhat.com> <1386954633-28905-16-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386954633-28905-16-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Introduce the "image" option as an alternative to specifying the image > through the filename. > > Signed-off-by: Max Reitz One thing I'd like to see, either in the next version or in a follow-up series, is to generalise open_image() into a block.c function. The main difference between blkdebug and blkverify seems to be that blkverify does image format probing on its main image. This can be a bool argument to open_image(). Reviewed-by: Kevin Wolf