From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VraDA-0002Hx-Oz for qemu-devel@nongnu.org; Fri, 13 Dec 2013 16:23:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VraD4-0002Ck-Pq for qemu-devel@nongnu.org; Fri, 13 Dec 2013 16:23:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VraD4-0002Cd-GK for qemu-devel@nongnu.org; Fri, 13 Dec 2013 16:23:46 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDLNjlF028687 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 16:23:45 -0500 Date: Fri, 13 Dec 2013 22:23:43 +0100 From: Kevin Wolf Message-ID: <20131213212343.GL3916@dhcp-200-207.str.redhat.com> References: <1386954633-28905-1-git-send-email-mreitz@redhat.com> <1386954633-28905-20-git-send-email-mreitz@redhat.com> <20131213204958.GG3916@dhcp-200-207.str.redhat.com> <52AB7587.9070904@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lCAWRPmW1mITcIfM" Content-Disposition: inline In-Reply-To: <52AB7587.9070904@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz --lCAWRPmW1mITcIfM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 13.12.2013 um 22:00 hat Eric Blake geschrieben: > On 12/13/2013 01:49 PM, Kevin Wolf wrote: > > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > >> Introduce an alias "error" for "errno", since using the latter for QMP > >> is sure to result in various syntax errors due to the name being used > >> directly as an identifier. > >> > >> Signed-off-by: Max Reitz > >=20 > > I can't say I like this, but it seems we don't have an option. >=20 > Don't we already have a way to use QMP keys that collide with C keywords > (for example, "unix" in qapi's SocketAddress becomes "q_unix" in C)? > Why can't we reuse that mechanism, and just add "errno" to the polluted > words list so that the generated C code uses "q_errno" rather than > having to invent an "error" alias? Oh, I didn't know that this exists. Sounds better then, because it makes the external interfaces uniform, even though internally we'd still have aliases (errno/q_errno instead of errno/error then). Kevin --lCAWRPmW1mITcIfM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBAgAGBQJSq3rfAAoJEH8JsnLIjy/W09QQALo463PASzJISs62/DgDhnw+ bbc858eYqfy84pcquAdG8x/FuFs1caLdxZC7O1BxkgyNcKYHoj0KwZpAbjcEVLQ8 z2YU7hALkEntaorbEzkSviSJ7W0/xx870xEJ/MTsnkd3yLeKQ1oauOpZHp/Q9sPi UME4nD6u8eN1I68mOY7whEqFmqu4tAl1juw7O89LZquuaTJ1syMYLXhIouRo31dT iz9PWiOfTlerV7jeCk00YKmJ/oKQdsEyWKmyYXejh5jybOcquI3DUrHgjSsOU0YW mlWxaHhvBiuoHDPZenY3xhJQBKNLNQgRLp7h3FC0Zbjg3TVRXn8jhTcnuEeFnUo9 WUqRihCGDucE+UuNnYfQVdxcwy2hI21MNQBi+X+qWrkatQy/FPqh/zW99ycdCuDN IZxDy8PfMUwjt8rkx7qj4QB1qwYb6Ex7MVdvf2Kz4D5YuFU+aERs0WJf3dTjLSV6 3IreSehSvHD6oSZyL/6lcSzXOfRIj07lHwQrLYG4u1wLfYpbgyKncOJqjKeylN78 ToEn/XQBoC7D5Li7Fr9lJb6icOiUNiMO6lFKXeamnJt1464JAxrOnX95E3dAwQlU xeDEGis6deNZc6Bz3yWcfLe4VyiWuwaau+69xYBktdhSM2dM/a7rWWGTJKbRUEQE n7IRXg51G93iRw3z8BYT =F/B9 -----END PGP SIGNATURE----- --lCAWRPmW1mITcIfM--