From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/4] dataplane: use more of the generic virtio data structures, drop hostmem
Date: Mon, 16 Dec 2013 17:16:46 +0100 [thread overview]
Message-ID: <20131216161646.GE16756@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1386678421-3500-1-git-send-email-pbonzini@redhat.com>
On Tue, Dec 10, 2013 at 01:26:57PM +0100, Paolo Bonzini wrote:
> Now that the memory API is thread-safe, we can use it in
> virtio-blk-dataplane and replace hostmem.[ch]. This series does this,
> and also changes the vring API to use VirtQueueElement (with an eye
> towards migration). With this change, virtio-blk-dataplane is also safe
> against memory hot-unplug.
>
> The next step would be to replace memory_region_find with
> address_space_{map,unmap}, which handle dirtying of memory correctly.
> However these APIs are not thread-safe yet, and neither is the handling
> of dirty memory (Juan's patches may be a start here).
>
> Also, the usage of iov_discard_{front,back} may cause some complication
> when we use address_space_{map,unmap}. We may have to change a bit the
> logic in virtio-blk-dataplane to switch to address_space_{map,unmap}.
>
> v1->v2: introduce vring_free_element
>
> Paolo Bonzini (4):
> vring: create a common function to parse descriptors
> vring: factor common code for error exits
> dataplane: change vring API to use VirtQueueElement
> dataplane: replace hostmem with memory_region_find
>
> hw/block/dataplane/virtio-blk.c | 86 +++++-------
> hw/virtio/dataplane/Makefile.objs | 2 +-
> hw/virtio/dataplane/hostmem.c | 183 ------------------------
> hw/virtio/dataplane/vring.c | 253 ++++++++++++++++++++++------------
> include/hw/virtio/dataplane/hostmem.h | 58 --------
> include/hw/virtio/dataplane/vring.h | 10 +-
> 6 files changed, 203 insertions(+), 389 deletions(-)
> delete mode 100644 hw/virtio/dataplane/hostmem.c
> delete mode 100644 include/hw/virtio/dataplane/hostmem.h
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2013-12-16 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 12:26 [Qemu-devel] [PATCH v2 0/4] dataplane: use more of the generic virtio data structures, drop hostmem Paolo Bonzini
2013-12-10 12:26 ` [Qemu-devel] [PATCH v2 1/4] vring: create a common function to parse descriptors Paolo Bonzini
2013-12-10 12:26 ` [Qemu-devel] [PATCH v2 2/4] vring: factor common code for error exits Paolo Bonzini
2013-12-10 12:27 ` [Qemu-devel] [PATCH v2 3/4] dataplane: change vring API to use VirtQueueElement Paolo Bonzini
2013-12-10 12:27 ` [Qemu-devel] [PATCH v2 4/4] dataplane: replace hostmem with memory_region_find Paolo Bonzini
2013-12-11 8:49 ` [Qemu-devel] [PATCH v2 0/4] dataplane: use more of the generic virtio data structures, drop hostmem Stefan Hajnoczi
2013-12-16 16:16 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216161646.GE16756@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).