From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1VsaTy-0001jt-GX
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 10:53:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1VsaTr-0000gQ-Nh
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 10:53:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37465)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1VsaTr-0000fC-6F
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 10:53:15 -0500
Date: Mon, 16 Dec 2013 16:53:03 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20131216165303.15ef73ea@nial.usersys.redhat.com>
In-Reply-To: <20131216162625.2e4353c7@nial.usersys.redhat.com>
References: <1386938688-22433-1-git-send-email-imammedo@redhat.com>
	<1386938688-22433-5-git-send-email-imammedo@redhat.com>
	<CAEgOgz4JmeGLo_cAha0DjY0ewo+wBwJpHPMeMF_GrcTu=2HoTA@mail.gmail.com>
	<20131216162625.2e4353c7@nial.usersys.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/11] qdev: add to BusState
 "hotplug-handler" link
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, marcel.a@redhat.com, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, alex.williamson@redhat.com, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, dkoch@verizon.co, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Mon, 16 Dec 2013 16:26:25 +0100
Igor Mammedov <imammedo@redhat.com> wrote:

> On Sat, 14 Dec 2013 17:05:57 +1000
> Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
> 
[...]
> > >
> > >      QTAILQ_INIT(&bus->children);
> > > +    object_property_add_link(obj, QDEV_HOTPLUG_HANDLER_PROPERTY,
> > > +                             TYPE_HOTPLUG_HANDLER,
> > > +                             (Object **)&bus->hotplug_handler, NULL);
> > 
> > I think failure of this is fatal. When the patches go through,
> > probably want to &error_abort.
[...]
> 
> But more to the point, bus could be created during hotplug, and
> we do not want to abort guest, instead hotplug operation should fail.
> In this case following setting of QDEV_HOTPLUG_HANDLER_PROPERTY
> will fail if object_property_add_link() failed before.

In following patches there is a couple places asking for being replaced
with &error_abort, so if your patches get in before respin, I'll gladly
use &error_abort there.