Re: [Qemu-devel] [PATCH v1 20/22] exec: Make cpu_memory_rw_debug use the CPUs AS

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Mon, Dec 16, 2013 at 01:48:10PM +0100, Andreas Färber wrote:
> Am 16.12.2013 09:06, schrieb edgar.iglesias@gmail.com:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > 
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > ---
> >  exec.c |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/exec.c b/exec.c
> > index 686f0d1..e672824 100644
> > --- a/exec.c
> > +++ b/exec.c
> > @@ -2669,6 +2669,7 @@ int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr,
> >      int l;
> >      hwaddr phys_addr;
> >      target_ulong page;
> > +    CPUArchState *env = cpu->env_ptr;
> >  
> >      while (len > 0) {
> >          page = addr & TARGET_PAGE_MASK;
> > @@ -2681,10 +2682,9 @@ int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr,
> >              l = len;
> >          phys_addr += (addr & ~TARGET_PAGE_MASK);
> >          if (is_write)
> > -            cpu_physical_memory_write_rom(&address_space_memory,
> > -                                          phys_addr, buf, l);
> > +            cpu_physical_memory_write_rom(env->as, phys_addr, buf, l);
> >          else
> > -            cpu_physical_memory_rw(phys_addr, buf, l, is_write);
> > +            address_space_rw(env->as, phys_addr, buf, l, 0);
> 
> Add braces for if and else while at it? :)

Fixed, thanks.