From: Stefan Hajnoczi <stefanha@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: "libvir-list@redhat.com" <libvir-list@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] hindsight on qcow2v3 format
Date: Tue, 17 Dec 2013 14:59:29 +0100 [thread overview]
Message-ID: <20131217135929.GA2708@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <52AF99D5.4050800@redhat.com>
On Mon, Dec 16, 2013 at 05:24:53PM -0700, Eric Blake wrote:
> Is it worth tweaking docs/specs/qcow2.txt to permanently change the
> incompatible_features field to be 4 bytes (76-79) and mandate that bytes
> 72-75 always be 0, as a conservative way to prevent other misbehavior of
> programs like libvirt 0.10.2 that have code paths that don't correctly
> validate for version 2 files? And if we ever really did hit a situation
> of having 31 or more incompatible features, I could envision using bit
> 31 as an incompatible_feature witness that tells new enough qemu to look
> at some other offset for remaining feature bits (thankfully, the
> semantics of the incompatible_feature field mean that older qemu that
> honors version 3 formats will reject a file with incompatible_feature
> bit 31 set), so this is no real loss in the number of potential
> incompatible features being added.
I don't think qcow2 changes are necessary, just make a libvirt 0.10.x
stable release that verifies the qcow2 version.
Stefan
prev parent reply other threads:[~2013-12-17 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 0:24 [Qemu-devel] hindsight on qcow2v3 format Eric Blake
2013-12-17 13:59 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217135929.GA2708@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=eblake@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).