From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsvMH-0001Om-UE for qemu-devel@nongnu.org; Tue, 17 Dec 2013 09:10:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsvMD-0003td-I7 for qemu-devel@nongnu.org; Tue, 17 Dec 2013 09:10:49 -0500 Received: from mail-ee0-x22b.google.com ([2a00:1450:4013:c00::22b]:46785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsvMD-0003tR-5e for qemu-devel@nongnu.org; Tue, 17 Dec 2013 09:10:45 -0500 Received: by mail-ee0-f43.google.com with SMTP id c13so2905450eek.30 for ; Tue, 17 Dec 2013 06:10:44 -0800 (PST) Date: Tue, 17 Dec 2013 15:10:40 +0100 From: Stefan Hajnoczi Message-ID: <20131217141040.GC2708@stefanha-thinkpad.redhat.com> References: <1387267030-20148-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387267030-20148-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH v2] block/iscsi: Fix compilation for libiscsi 1.4.0 (API change) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Kevin Wolf , Ronnie Sahlberg , Peter Lieven , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini On Tue, Dec 17, 2013 at 08:57:10AM +0100, Stefan Weil wrote: > Function iscsi_read10_task got additional parameters starting with version > libiscsi 1.5.0. > > libiscsi 1.4.0 is still widely used (Debian wheezy, jessie and other Linux > distributions currently provide packages for QEMU which use it), so we > still need support for this older API. > > Reviewed-by: Peter Lieven > Signed-off-by: Stefan Weil > --- > > v2: Fixed libscsi -> libiscsi > > block/iscsi.c | 5 ++++- > configure | 22 ++++++++++++++++++++++ > 2 files changed, 26 insertions(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan