From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VswvL-0006fx-Lq for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:51:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vswv9-0001Ai-VQ for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:51:07 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:45125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vswv9-00019l-Nm for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:50:55 -0500 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Dec 2013 08:50:54 -0700 Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 062ED3E4003F for ; Tue, 17 Dec 2013 08:50:52 -0700 (MST) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by b03cxnp08025.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rBHFopCg62259412 for ; Tue, 17 Dec 2013 16:50:51 +0100 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id rBHFrtTs003683 for ; Tue, 17 Dec 2013 08:53:56 -0700 Date: Tue, 17 Dec 2013 16:50:49 +0100 From: Jens Freimann Message-ID: <20131217155049.GA540@linux.vnet.ibm.com> References: <1387286530-31516-1-git-send-email-jfrei@linux.vnet.ibm.com> <1387286530-31516-9-git-send-email-jfrei@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Christian Borntraeger , QEMU Developers , Thomas Huth On Tue, Dec 17, 2013 at 03:01:43PM +0100, Alexander Graf wrote: > > On 17.12.2013, at 14:22, Jens Freimann wrote: > > > From: Thomas Huth > > > > I missed to set the CC in the CHSC instruction when I refactored > > the CC setting in the IO instructions with the following commit: > > 5d9bf1c07c1369ab3506fc82cc65a10f4415d867 > > s390/ioinst: Moved the CC setting to the IO instruction handlers > > This patch now restores the correct behaviour of CHSC by setting the > > condition code 0 at the end of the instruction. > > > > Signed-off-by: Thomas Huth > > Reviewed-by: Cornelia Huck > > Signed-off-by: Jens Freimann > > I suppose this patch should be CC'ed to stable? Good point, I'll send it again with stable on CC. Same thing for Patch 1/8. Thanks! regards Jens > > Alex > > > --- > > target-s390x/ioinst.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/target-s390x/ioinst.c b/target-s390x/ioinst.c > > index 8d6363d..b8a6486 100644 > > --- a/target-s390x/ioinst.c > > +++ b/target-s390x/ioinst.c > > @@ -622,6 +622,7 @@ void ioinst_handle_chsc(S390CPU *cpu, uint32_t ipb) > > break; > > } > > > > + setcc(cpu, 0); /* Command execution complete */ > > out: > > s390_cpu_physical_memory_unmap(env, req, map_size, 1); > > } > > -- > > 1.8.3.4 > > > >