qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [qemu-kvm PATCH] docs: updated qemu-img man page and qemu-doc to reflect VHDX support.
Date: Tue, 17 Dec 2013 13:54:43 -0500	[thread overview]
Message-ID: <20131217185443.GA6804@localhost.localdomain> (raw)
In-Reply-To: <52B09D45.9020700@weilnetz.de>

On Tue, Dec 17, 2013 at 07:51:49PM +0100, Stefan Weil wrote:
> Am 17.12.2013 19:41, schrieb Jeff Cody:
> > The man page for qemu-img, and the qemu-doc, did not mention VHDX
> > as a supported format.  This adds in reference to VHDX in those
> > documents.
> >
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > ---
> >  qemu-doc.texi | 15 +++++++++++++++
> >  qemu-img.texi |  4 ++--
> >  2 files changed, 17 insertions(+), 2 deletions(-)
> >
> > diff --git a/qemu-doc.texi b/qemu-doc.texi
> > index 185dd47..10b4ae9 100644
> > --- a/qemu-doc.texi
> > +++ b/qemu-doc.texi
> > @@ -654,6 +654,21 @@ Supported options:
> >  Specifies which VHD subformat to use. Valid options are
> >  @code{dynamic} (default) and @code{fixed}.
> >  @end table
> > +
> > +@item VHDX
> > +Hyper-V compatible image format (VHDX).
> > +Supported options:
> > +@table @code
> > +@item subformat
> > +Specifies which VHDX subformat to use. Valid options are
> > +@code{dynamic} (default) and @code{fixed}.
> > +@item block_state_zero
> > +Force use of payload blocks of type 'ZERO'.
> > +@item block_size
> > +Block Size; min 1MB, max 256MB.  0 means auto-calculate based on image size.
> 
> Please add blanks: 1 MB, max 256 MB.
> 
> > +@item log_size
> > +Log size; min 1MB.
> 
> 1 MB
>

OK, thanks.

> > +@end table
> >  @end table
> >  
> >  @subsubsection Read-only formats
> > diff --git a/qemu-img.texi b/qemu-img.texi
> > index be31191..1bba91e 100644
> > --- a/qemu-img.texi
> > +++ b/qemu-img.texi
> > @@ -431,8 +431,8 @@ This option can only be enabled if @code{compat=1.1} is specified.
> >  
> >  @item Other
> >  QEMU also supports various other image file formats for compatibility with
> > -older QEMU versions or other hypervisors, including VMDK, VDI, VHD (vpc), qcow1
> > -and QED. For a full list of supported formats see @code{qemu-img --help}.
> > +older QEMU versions or other hypervisors, including VMDK, VDI, VHD (vpc), VHDX,
> > +qcow1 and QED. For a full list of supported formats see @code{qemu-img --help}.
> >  For a more detailed description of these formats, see the QEMU Emulation User
> >  Documentation.
> 
> Otherwise okay. I appreciate efforts to improve the documentation.
> 
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
> 

      reply	other threads:[~2013-12-17 18:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 18:41 [Qemu-devel] [qemu-kvm PATCH] docs: updated qemu-img man page and qemu-doc to reflect VHDX support Jeff Cody
2013-12-17 18:51 ` Stefan Weil
2013-12-17 18:54   ` Jeff Cody [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217185443.GA6804@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).