From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, and .bdrv_check implementation
Date: Wed, 18 Dec 2013 14:52:39 +0100 [thread overview]
Message-ID: <20131218135239.GB4102@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <184d3b68e1da2f5b0dd80e06416836286e3f840f.1387276279.git.jcody@redhat.com>
On Tue, Dec 17, 2013 at 05:33:37AM -0500, Jeff Cody wrote:
> If there is a dirty log file to be replayed in a VHDX image, it is
> replayed in .vhdx_open(). However, if the file is opened read-only,
> then a somewhat cryptic error message results.
>
> This adds a more helpful error message for the user. If an image file
> contains a log to be replayed, and is opened read-only, the user is
> instructed to run 'qemu-img check -r all' on the image file.
>
> Running qemu-img check -r all will cause the image file to be opened
> r/w, which will replay the log file. If a log file replay is detected,
> this is flagged, and bdrv_check will increase the corruptions_fixed
> count for the image.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> block/vhdx-log.c | 12 +++++++++++-
> block/vhdx.c | 22 ++++++++++++++++++++--
> block/vhdx.h | 5 ++++-
> 3 files changed, 35 insertions(+), 4 deletions(-)
Merged "to be replayed" typo fix when applying the patch.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2013-12-18 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 10:33 [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, and .bdrv_check implementation Jeff Cody
2013-12-17 13:56 ` Eric Blake
2013-12-17 15:38 ` Jeff Cody
2013-12-17 15:44 ` Eric Blake
2013-12-18 13:52 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218135239.GB4102@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).