From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtHYO-0005Si-Op for qemu-devel@nongnu.org; Wed, 18 Dec 2013 08:52:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtHYK-0001gA-0S for qemu-devel@nongnu.org; Wed, 18 Dec 2013 08:52:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtHYJ-0001g6-P8 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 08:52:43 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIDqgd1003103 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 08:52:42 -0500 Date: Wed, 18 Dec 2013 14:52:39 +0100 From: Stefan Hajnoczi Message-ID: <20131218135239.GB4102@stefanha-thinkpad.redhat.com> References: <184d3b68e1da2f5b0dd80e06416836286e3f840f.1387276279.git.jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <184d3b68e1da2f5b0dd80e06416836286e3f840f.1387276279.git.jcody@redhat.com> Subject: Re: [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, and .bdrv_check implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, qemu-devel@nongnu.org On Tue, Dec 17, 2013 at 05:33:37AM -0500, Jeff Cody wrote: > If there is a dirty log file to be replayed in a VHDX image, it is > replayed in .vhdx_open(). However, if the file is opened read-only, > then a somewhat cryptic error message results. > > This adds a more helpful error message for the user. If an image file > contains a log to be replayed, and is opened read-only, the user is > instructed to run 'qemu-img check -r all' on the image file. > > Running qemu-img check -r all will cause the image file to be opened > r/w, which will replay the log file. If a log file replay is detected, > this is flagged, and bdrv_check will increase the corruptions_fixed > count for the image. > > Signed-off-by: Jeff Cody > --- > block/vhdx-log.c | 12 +++++++++++- > block/vhdx.c | 22 ++++++++++++++++++++-- > block/vhdx.h | 5 ++++- > 3 files changed, 35 insertions(+), 4 deletions(-) Merged "to be replayed" typo fix when applying the patch. Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan