From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtK5K-00007f-BN for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:35:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtK5E-0000nT-Cz for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:34:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtK5E-0000nL-3R for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:34:52 -0500 Date: Wed, 18 Dec 2013 17:34:37 +0100 From: Igor Mammedov Message-ID: <20131218173437.15d52c37@nial.usersys.redhat.com> In-Reply-To: <20131218162607.GA21916@redhat.com> References: <1386938688-22433-1-git-send-email-imammedo@redhat.com> <87r49c1ioi.fsf@codemonkey.ws> <52B045BB.6010900@redhat.com> <52B17AC4.6080709@redhat.com> <20131218164809.7b4ddb07@nial.usersys.redhat.com> <20131218162607.GA21916@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Kevin Wolf , Peter Maydell , Peter Crosthwaite , Eduardo Habkost , marcel.a@redhat.com, qemu-devel , Blue Swirl , Alex Williamson , Gerd Hoffmann , Anthony Liguori , Paolo Bonzini , dkoch@verizon.co, Andreas =?ISO-8859-1?B?RuRyYmVy?= On Wed, 18 Dec 2013 18:26:07 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 18, 2013 at 04:48:09PM +0100, Igor Mammedov wrote: > > On Wed, 18 Dec 2013 11:36:52 +0100 > > Paolo Bonzini wrote: > > > > > Il 17/12/2013 20:38, Anthony Liguori ha scritto: > > > > On Tue, Dec 17, 2013 at 4:38 AM, Paolo Bonzini wrote: > > > >> Il 17/12/2013 00:26, Anthony Liguori ha scritto: > > > >>> Sharing hot plug code is a good thing. Making hotplug a qdev-level > > > >>> concept seems like a bad thing to me. > > > >> > > > >> Can you explain what you mean? > > > > > > > > The question is whether "hotpluggable" as a property applies to all > > > > devices or not. > > I think Andreas asked me to provide "hotpluggable" property to > > distinguish hotpluggable vs not hotpluggable DimmDevice via qom interface. > > > > > > > > > > But hotplug is strictly a bus level concept. It's a sequence of > > > > events that correspond to what happens when you add a new device to a > > > > bus after power on. > > > > > > Hotplugging a device is a special case of plugging a device. If a bus > > > or device only supports cold-plug, that can be done using > > > "bc->allow_hotplug = false" or "dc->hotpluggable = false". > > Do we need per instance ability to set "hotpluggable" property? > > For example board might want to mark some CPUs as not hotpluggable. > > It could be useful. > In real life same device can be on-board or on a plugin card. > But it's not a must, we survived without this so far. > > So maybe start not supporting it, add later? > Yes, that's surely could be done later > > > > > > Paolo > > >