From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47488)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1VtXg6-0000fK-N4
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 02:05:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1VtXfy-00042c-Pv
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 02:05:50 -0500
Received: from mail-pd0-x232.google.com ([2607:f8b0:400e:c02::232]:63588)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1VtXfy-00042U-H1
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 02:05:42 -0500
Received: by mail-pd0-f178.google.com with SMTP id y10so735264pdj.37
	for <qemu-devel@nongnu.org>; Wed, 18 Dec 2013 23:05:41 -0800 (PST)
Date: Thu, 19 Dec 2013 17:05:07 +1000
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20131219070506.GA26842@edvb>
References: <1387432293-17711-1-git-send-email-edgar.iglesias@gmail.com>
	<1387432293-17711-21-git-send-email-edgar.iglesias@gmail.com>
	<CAEgOgz6k-j1Mj8p7-Yt9x8gawjOPdWK54OzgZsc2ccdEw6+03w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEgOgz6k-j1Mj8p7-Yt9x8gawjOPdWK54OzgZsc2ccdEw6+03w@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 20/22] target-microblaze: Add
 address-space property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@amazon.com>, Peter Crosthwaite <pcrost@xilinx.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

On Thu, Dec 19, 2013 at 04:22:47PM +1000, Peter Crosthwaite wrote:
> On Thu, Dec 19, 2013 at 3:51 PM,  <edgar.iglesias@gmail.com> wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> >
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > ---
> >  target-microblaze/cpu.c |    6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> > index 0ef9aa4..6d39d3d 100644
> > --- a/target-microblaze/cpu.c
> > +++ b/target-microblaze/cpu.c
> > @@ -93,6 +93,9 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **errp)
> >      CPUState *cs = CPU(dev);
> >      MicroBlazeCPUClass *mcc = MICROBLAZE_CPU_GET_CLASS(dev);
> >
> > +#ifndef CONFIG_USER_ONLY
> > +    cpu_address_space_init(cs, cs->as);
> > +#endif
> >      cpu_reset(cs);
> >      qemu_init_vcpu(cs);
> >
> > @@ -123,6 +126,9 @@ static const VMStateDescription vmstate_mb_cpu = {
> >  };
> >
> >  static Property mb_properties[] = {
> > +#ifndef CONFIG_USER_ONLY
> > +    DEFINE_PROP_ADDRESS_SPACE("address-space", CPUState, as),
> > +#endif
> 
> Why not add it as a property on the base CPU level?
> 

Hi,

Yes, I can have a look at doing that. It will probably involve having some
kind of implementation of the AS prop for user emulation as qom/cpu.o is
supposed to be common for both. Andreas, do you have any preferences on how
this should be done?

Thanks,
Edgar