From: Stefan Hajnoczi <stefanha@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Alexander Graf" <agraf@suse.de>,
"Andreas Färber" <afaerber@suse.de>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification
Date: Thu, 19 Dec 2013 10:30:49 +0100 [thread overview]
Message-ID: <20131219093049.GA2537@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <87haa6ytr0.fsf@blackfin.pond.sub.org>
On Wed, Dec 18, 2013 at 06:05:39PM +0100, Markus Armbruster wrote:
> Andreas Färber <afaerber@suse.de> writes:
>
> > I had a brief look at this series. Dropping redundant fields certainly
> > sounds good and after the lengthy QOM'ifications of IDE devices we seem
> > to no longer break any devices, but whether to check for device or
> > BlockDriverState sounds more like a block topic to me...
>
> I read that as "ack from a block maintainer wanted for '[PATCH v2 2/9]
> ide: Use IDEState member dev for "device connected" test'". Correct?
IDE is not something I'm familiar with so I suggest we wait for Kevin to
return from vacation.
Stefan
prev parent reply other threads:[~2013-12-19 9:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 9:55 [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 1/9] ide: Move IDEDevice pointer from IDEBus to IDEState armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 2/9] ide: Use IDEState member dev for "device connected" test armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 3/9] ide: Don't block-align IDEState member smart_selftest_data armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 4/9] ide: Drop redundant IDEState member bs armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 5/9] ide: Drop redundant IDEState geometry members armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 6/9] ide: Drop redundant IDEState member version armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 7/9] ide: Drop redundant IDEState member drive_serial_str armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 8/9] ide: Drop redundant IDEState member model armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 9/9] ide: Drop redundant IDEState member wwn armbru
2013-12-18 14:54 ` [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification Markus Armbruster
2013-12-18 15:38 ` Andreas Färber
2013-12-18 17:05 ` Markus Armbruster
2013-12-19 9:30 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219093049.GA2537@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).