From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtd6S-0002Lt-UE for qemu-devel@nongnu.org; Thu, 19 Dec 2013 07:53:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vtd6N-00053f-KP for qemu-devel@nongnu.org; Thu, 19 Dec 2013 07:53:24 -0500 Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:64355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtd6N-00053R-C4 for qemu-devel@nongnu.org; Thu, 19 Dec 2013 07:53:19 -0500 Received: by mail-we0-f170.google.com with SMTP id w61so1025859wes.1 for ; Thu, 19 Dec 2013 04:53:18 -0800 (PST) Date: Thu, 19 Dec 2013 13:53:07 +0100 From: Stefan Hajnoczi Message-ID: <20131219125307.GB2537@stefanha-thinkpad.redhat.com> References: <1386566676-12353-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386566676-12353-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] vmdk: Check VMFS extent line field number List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Dec 09, 2013 at 01:24:36PM +0800, Fam Zheng wrote: > VMFS extent line in description file should be with 4 fields: > > RW VMFS "file-name.vmdk" > > Check the number explicitly and report error if offset is appended as > FLAT, which should be invalid format. > > Reported-by: Paolo Bonzini > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 9 +++++++-- > tests/qemu-iotests/059 | 14 ++++++++++++++ > tests/qemu-iotests/059.out | 5 +++++ > 3 files changed, 26 insertions(+), 2 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan