From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: stefanha@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org,
brogers@suse.com, jjherne@us.ibm.com, kraxel@redhat.com,
aliguori@amazon.com, kaneshige.kenji@jp.fujitsu.com,
chen.fan.fnst@cn.fujitsu.com, pbonzini@redhat.com,
lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH 05/11] acpi: ich9: allow guest to clear SCI rised by GPE
Date: Thu, 19 Dec 2013 16:16:58 +0200 [thread overview]
Message-ID: <20131219141658.GD10117@redhat.com> (raw)
In-Reply-To: <1386951736-929-6-git-send-email-imammedo@redhat.com>
On Fri, Dec 13, 2013 at 05:22:10PM +0100, Igor Mammedov wrote:
> it fixes IRQ storm since guest isn't able to lower SCI IRQ
> after it has been handled when it clears GPE event.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Applied, thanks.
> ---
> hw/acpi/ich9.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index dcdef7c..30f0df8 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> @@ -61,6 +61,7 @@ static void ich9_gpe_writeb(void *opaque, hwaddr addr, uint64_t val,
> {
> ICH9LPCPMRegs *pm = opaque;
> acpi_gpe_ioport_writeb(&pm->acpi_regs, addr, val);
> + acpi_update_sci(&pm->acpi_regs, pm->irq);
> }
>
> static const MemoryRegionOps ich9_gpe_ops = {
> --
> 1.8.3.1
next prev parent reply other threads:[~2013-12-19 14:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 16:22 [Qemu-devel] [PATCH 00/11] pc: CPU hotplug support for Q35 Igor Mammedov
2013-12-13 16:22 ` [Qemu-devel] [PATCH 01/11] acpi: piix4: remove not needed GPE0 mask Igor Mammedov
2013-12-19 14:16 ` Michael S. Tsirkin
2013-12-13 16:22 ` [Qemu-devel] [PATCH 02/11] acpi: factor out common pm_update_sci() into acpi core Igor Mammedov
2013-12-19 14:16 ` Michael S. Tsirkin
2013-12-13 16:22 ` [Qemu-devel] [PATCH 03/11] acpi: factor out common cpu hotplug code for PIIX4/Q35 Igor Mammedov
2013-12-19 14:14 ` Michael S. Tsirkin
2013-12-19 15:13 ` Igor Mammedov
2013-12-13 16:22 ` [Qemu-devel] [PATCH 04/11] acpi/piix4: add readonly "cpu-hotplug-io-base" property Igor Mammedov
2013-12-13 16:22 ` [Qemu-devel] [PATCH 05/11] acpi: ich9: allow guest to clear SCI rised by GPE Igor Mammedov
2013-12-19 14:16 ` Michael S. Tsirkin [this message]
2013-12-13 16:22 ` [Qemu-devel] [PATCH 06/11] acpi/ich9: add CPU hotplug handling to Q35 machine Igor Mammedov
2013-12-19 14:18 ` Michael S. Tsirkin
2013-12-19 15:17 ` Igor Mammedov
2013-12-19 15:33 ` Michael S. Tsirkin
2013-12-13 16:22 ` [Qemu-devel] [PATCH 07/11] ACPI: Q35 DSDT: fix CPU hotplug GPE0.2 handler Igor Mammedov
2013-12-13 16:22 ` [Qemu-devel] [PATCH 08/11] ACPI/DSDT-CPU: cleanup bogus comment Igor Mammedov
2013-12-13 16:22 ` [Qemu-devel] [PATCH 09/11] ACPI: move PRST OperationRegion into SSDT Igor Mammedov
2013-12-16 19:30 ` Michael S. Tsirkin
2013-12-16 20:38 ` Igor Mammedov
2013-12-16 21:13 ` Laszlo Ersek
2013-12-16 21:22 ` Laszlo Ersek
2013-12-16 21:53 ` Igor Mammedov
2013-12-17 10:39 ` Michael S. Tsirkin
2013-12-16 21:44 ` Laszlo Ersek
2013-12-16 21:59 ` Igor Mammedov
2013-12-16 22:22 ` Laszlo Ersek
2013-12-16 23:13 ` Igor Mammedov
2013-12-16 19:53 ` Michael S. Tsirkin
2013-12-16 22:15 ` Igor Mammedov
2013-12-22 14:51 ` Igor Mammedov
2013-12-23 11:26 ` Michael S. Tsirkin
2013-12-23 13:06 ` Igor Mammedov
2013-12-23 14:48 ` Michael S. Tsirkin
2013-12-23 16:24 ` Igor Mammedov
2013-12-23 16:52 ` Laszlo Ersek
2013-12-28 0:39 ` Igor Mammedov
2013-12-23 16:55 ` Michael S. Tsirkin
2013-12-13 16:22 ` [Qemu-devel] [PATCH 10/11] ACPI: set CPU hotplug io base dynamically Igor Mammedov
2013-12-13 16:22 ` [Qemu-devel] [PATCH 11/11] ACPI: update ssdt-misc.hex.generated acpi-dsdt.hex.generated q35-acpi-dsdt.hex.generated Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219141658.GD10117@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=brogers@suse.com \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=jjherne@us.ibm.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).