From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qdev-monitor-test: simplify using g_assert_cmpstr()
Date: Thu, 19 Dec 2013 16:38:07 +0100 [thread overview]
Message-ID: <20131219153807.GA9087@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <52B1EA14.7050700@suse.de>
On Wed, Dec 18, 2013 at 07:31:48PM +0100, Andreas Färber wrote:
> Am 18.12.2013 17:34, schrieb Stefan Hajnoczi:
> > Use g_assert_cmpstr() instead of combining g_assert() and strcmp(3).
>
> I vaguely remember that some such handy function was introduced only
> after the minimum GLib version we require. Did you check on that?
> But IIRC we already have higher requirements for qtest that for the
> non-check code so it might not really matter...
Yes, before using it I did git grep g_assert_cmpstr. It's already used
in many other test cases like tests/check-qjson.c.
Stefan
prev parent reply other threads:[~2013-12-19 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 16:34 [Qemu-devel] [PATCH] qdev-monitor-test: simplify using g_assert_cmpstr() Stefan Hajnoczi
2013-12-18 17:11 ` Markus Armbruster
2013-12-18 17:49 ` Andreas Färber
2013-12-18 18:31 ` Andreas Färber
2013-12-19 15:38 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219153807.GA9087@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).