From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtfg5-00054m-6w for qemu-devel@nongnu.org; Thu, 19 Dec 2013 10:38:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vtffz-0000YL-7L for qemu-devel@nongnu.org; Thu, 19 Dec 2013 10:38:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtffy-0000Y8-Vt for qemu-devel@nongnu.org; Thu, 19 Dec 2013 10:38:15 -0500 Date: Thu, 19 Dec 2013 16:38:07 +0100 From: Stefan Hajnoczi Message-ID: <20131219153807.GA9087@stefanha-thinkpad.redhat.com> References: <1387384489-25671-1-git-send-email-stefanha@redhat.com> <52B1EA14.7050700@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <52B1EA14.7050700@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qdev-monitor-test: simplify using g_assert_cmpstr() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qemu-devel@nongnu.org, Markus Armbruster On Wed, Dec 18, 2013 at 07:31:48PM +0100, Andreas F=E4rber wrote: > Am 18.12.2013 17:34, schrieb Stefan Hajnoczi: > > Use g_assert_cmpstr() instead of combining g_assert() and strcmp(3). >=20 > I vaguely remember that some such handy function was introduced only > after the minimum GLib version we require. Did you check on that? > But IIRC we already have higher requirements for qtest that for the > non-check code so it might not really matter... Yes, before using it I did git grep g_assert_cmpstr. It's already used in many other test cases like tests/check-qjson.c. Stefan