From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtj0v-0001Zv-CB for qemu-devel@nongnu.org; Thu, 19 Dec 2013 14:12:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vtj0p-0002Gc-C5 for qemu-devel@nongnu.org; Thu, 19 Dec 2013 14:12:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtj0p-0002GS-43 for qemu-devel@nongnu.org; Thu, 19 Dec 2013 14:11:59 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJJBvjV002916 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 Dec 2013 14:11:58 -0500 Date: Thu, 19 Dec 2013 21:15:48 +0200 From: "Michael S. Tsirkin" Message-ID: <20131219191548.GA7297@redhat.com> References: <1386348867-25038-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386348867-25038-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Fri, Dec 06, 2013 at 05:54:23PM +0100, Paolo Bonzini wrote: > PCI is handling resetting of its devices before the bus is reset, > but this is only necessary because qdev is broken and usually does > pre-order reset. Post-order is a much better definition. Drop > the unnecessary flexibility that lets bus decide the reset order, > convert to post-order, and make PCI use common code for reset. > > Paolo Bonzini (4): > pci: do not export pci_bus_reset > pci: clean up resetting of IRQs > qdev: allow both pre- and post-order vists in qdev walking functions > qdev: switch reset to post-order Applied, thanks! I had to fix the last patch as it broke virtio ccw though. Also, waiting for tests to start passing on master again before I send pull request. > hw/core/qdev.c | 47 ++++++++++++++++++++++++++++++++++------------- > hw/pci/pci.c | 42 ++++++++++++++++++++---------------------- > hw/pci/pci_bridge.c | 2 +- > include/hw/pci/pci.h | 1 - > include/hw/qdev-core.h | 15 ++++++++++----- > 5 files changed, 65 insertions(+), 42 deletions(-)