Re: [Qemu-devel] [PATCH v2] vmdk: Allow vmdk_create to work with protocol

[Stefan Hajnoczi <stefanha@redhat.com>]

On Fri, Dec 20, 2013 at 09:48:48AM +0800, Fam Zheng wrote:
> This improves vmdk_create to use bdrv_* functions to replace qemu_open
> and other fd functions. The error handling are improved as well. One
> difference is that bdrv_pwrite will round up buffer to sectors, so for
> description file, an extra bdrv_truncate is used in the end to drop
> inding zeros.
> 
> Notes:
> 
>  - A bonus bug fix is correct endian is used in initializing GD entries.
> 
>  - ROUND_UP and DIV_ROUND_UP are used where possible.
> 
> I tested that new code produces exactly the same file as previously.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> v2: Address Stefan's comments:
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/vmdk.c | 164 ++++++++++++++++++++++++++++++++++-------------------------
>  1 file changed, 95 insertions(+), 69 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan